fix(config): Don't print sensitive config when setting them

Signed-off-by: Carl Schwan <carl@carlschwan.eu>

Author: CarlSchwan

core/Command/Config/System/SetConfig.php

@@ -9,6 +9,7 @@
 namespace OC\Core\Command\Config\System;
 
 use OC\SystemConfig;
+use OCP\IConfig;
 use Stecman\Component\Symfony\Console\BashCompletion\CompletionContext;
 use Symfony\Component\Console\Input\InputArgument;
 use Symfony\Component\Console\Input\InputInterface;
@@ -80,10 +81,41 @@ protected function execute(InputInterface $input, OutputInterface $output): int
 			$this->systemConfig->setValue($configName, $configValue['value']);
 		}
 
-		$output->writeln('<info>System config value ' . implode(' => ', $configNames) . ' set to ' . $configValue['readable-value'] . '</info>');
+		$readableValue = $this->getReadableValue($configNames, $configValue);
+
+		$output->writeln('<info>System config value ' . implode(' => ', $configNames) . ' set to ' . $readableValue . '</info>');
 		return 0;
 	}
 
+	/**
+	 * Builds the value to print for the console output, masking it (or the
+	 * sensitive parts of it) in case the config key is considered sensitive
+	 * by SystemConfig.
+	 *
+	 * @param string[] $configNames
+	 * @param array{value: mixed, readable-value: string} $configValue
+	 */
+	protected function getReadableValue(array $configNames, array $configValue): string {
+		$filteredValue = $this->systemConfig->getFilteredValue($configNames[0]);
+		foreach (array_slice($configNames, 1) as $key) {
+			if (!is_array($filteredValue) || !array_key_exists($key, $filteredValue)) {
+				// Nothing got filtered along this path
+				return $configValue['readable-value'];
+			}
+			$filteredValue = $filteredValue[$key];
+		}
+
+		if ($filteredValue === $configValue['value']) {
+			return $configValue['readable-value'];
+		}
+
+		if ($filteredValue === IConfig::SENSITIVE_VALUE) {
+			return IConfig::SENSITIVE_VALUE;
+		}
+
+		return 'array ' . json_encode($filteredValue);
+	}
+
 	/**
 	 * @param array $configNames
 	 * @param mixed $existingValues