Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't re-add deleted feed via API #2957

Open
3 tasks done
cheywood opened this issue Dec 2, 2024 · 5 comments
Open
3 tasks done

Can't re-add deleted feed via API #2957

cheywood opened this issue Dec 2, 2024 · 5 comments
Labels

Comments

@cheywood
Copy link

cheywood commented Dec 2, 2024

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

  • I have read the CONTRIBUTING.md and followed the provided tips
  • I accept that the issue will be closed without comment if I do not check here
  • I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

A feed that has been removed in the UI can not be re-added via the API (as it appears to still exist?). I haven't checked the DB, presumably it's still there.

Steps to Reproduce

Explain what you did to encounter the issue

  1. Remove a feed from the UI
  2. Use API to attempt to add the feed
  3. Recieve status code 409 with message Feed with this URL exists

System Information

  • News app version: 25.1.0
  • Nextcloud version: 29.0.9
  • Browser and version: Firefox 133.0
  • Cron type: Cron
  • PHP version: 8.3.14
  • Database and version: MariaDB 10.5.23
  • OS and version: Client or server? Either way Debian, 11 on server, testing on client.

edit: further server details

@cheywood cheywood added the bug label Dec 2, 2024
@Grotax
Copy link
Member

Grotax commented Dec 2, 2024

The reason is that the feed is marked for deletion, in theory the clients web-ui, API clients can restore a deleted feed.

The feed is actually deleted when the update job is run by nextcloud by default every hour.

@wofferl
Copy link
Collaborator

wofferl commented Dec 2, 2024

I think we can re-add that feature and expand the check so currently removed feeds can be added again.

@wofferl wofferl added frontend impact Javascript/Frontend code and removed frontend impact Javascript/Frontend code labels Dec 2, 2024
@wofferl
Copy link
Collaborator

wofferl commented Dec 2, 2024

I have misread the post. I thought you mean re-adding the feed with the UI. This works and the undo feature can maybe implemented some times later.

@cheywood
Copy link
Author

cheywood commented Dec 2, 2024

The reason is that the feed is marked for deletion

That's right 👍 I can see that now after doing some API integration testing.

So perhaps a better phrasing of this would be "Instead of failing, an API request to add a feed which is currently flagged deleted should restore it".

@cheywood
Copy link
Author

cheywood commented Dec 4, 2024

I think I maybe also spotted a "deleted" feed interfering with OPML import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants