From 3aa145d66e5bc2aae285b412510c7ea9f0a9e2a5 Mon Sep 17 00:00:00 2001 From: Stefan Lender Date: Mon, 7 Sep 2026 12:00:15 +0200 Subject: [PATCH 1/2] fix(TeamSpace): include quota in TeamFolder instantiation and update tests Co-authored-by: Copilot GPT-5.6 Terra Signed-off-by: Stefan Lender --- lib/TeamSpace/TeamSpaceService.php | 4 ++-- tests/TeamSpace/TeamSpaceServiceTest.php | 6 +++++- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/TeamSpace/TeamSpaceService.php b/lib/TeamSpace/TeamSpaceService.php index 969b780b2..7f37bafbe 100644 --- a/lib/TeamSpace/TeamSpaceService.php +++ b/lib/TeamSpace/TeamSpaceService.php @@ -233,7 +233,7 @@ public function getTeamSpaceForCircle(string $circleId): ?TeamFolder { $this->createAppDirectory($folderId); - return new TeamFolder($folder->id, $folder->mountPoint); + return new TeamFolder($folder->id, $folder->mountPoint, $folder->quota); } /** @@ -257,7 +257,7 @@ public function updateTeamSpaceQuota(string $circleId, int $quota): TeamFolder { throw new \RuntimeException('Team space could not be found after updating quota'); } - return new TeamFolder($folder->id, $folder->mountPoint); + return new TeamFolder($folder->id, $folder->mountPoint, $quota); } /** diff --git a/tests/TeamSpace/TeamSpaceServiceTest.php b/tests/TeamSpace/TeamSpaceServiceTest.php index a2b6a99c8..b80e9734f 100644 --- a/tests/TeamSpace/TeamSpaceServiceTest.php +++ b/tests/TeamSpace/TeamSpaceServiceTest.php @@ -121,7 +121,10 @@ public function testGetTeamSpaceForCircleDoesNotRecreateExistingAppDirectory(): $storage->expects($this->never())->method('mkdir'); $storage->expects($this->never())->method('getScanner'); - $this->assertSame(42, $this->service->getTeamSpaceForCircle('team-1')?->getId()); + $folder = $this->service->getTeamSpaceForCircle('team-1'); + + $this->assertSame(42, $folder?->getId()); + $this->assertSame(0, $folder?->getQuota()); } public function testUnlinkKeepsFolderAndClearsTeamLink(): void { @@ -150,6 +153,7 @@ public function testUpdateTeamSpaceQuotaReturnsUpdatedFolder(): void { $this->assertSame(42, $folder->getId()); $this->assertSame('Engineering', $folder->getMountPoint()); + $this->assertSame(1024, $folder->getQuota()); } public function testGetGroupFoldersForCircleReturnsAllAssignedFolders(): void { From 73796e80684641399e46ad4ad209d78377bdda7c Mon Sep 17 00:00:00 2001 From: Stefan Lender Date: Mon, 7 Sep 2026 12:30:58 +0200 Subject: [PATCH 2/2] fix(TeamSpaceServiceTest): remove nullsafe operator for folder assertions Co-authored-by: Copilot GPT-5.6 Sol Signed-off-by: Stefan Lender --- tests/TeamSpace/TeamSpaceServiceTest.php | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/TeamSpace/TeamSpaceServiceTest.php b/tests/TeamSpace/TeamSpaceServiceTest.php index b80e9734f..cef66d756 100644 --- a/tests/TeamSpace/TeamSpaceServiceTest.php +++ b/tests/TeamSpace/TeamSpaceServiceTest.php @@ -18,6 +18,7 @@ use OCP\Files\Cache\IScanner; use OCP\Files\Storage\IStorage; use OCP\Teams\Team; +use OCP\Teams\TeamFolder; use PHPUnit\Framework\MockObject\MockObject; use Psr\Log\LoggerInterface; use Test\TestCase; @@ -123,8 +124,9 @@ public function testGetTeamSpaceForCircleDoesNotRecreateExistingAppDirectory(): $folder = $this->service->getTeamSpaceForCircle('team-1'); - $this->assertSame(42, $folder?->getId()); - $this->assertSame(0, $folder?->getQuota()); + $this->assertInstanceOf(TeamFolder::class, $folder); + $this->assertSame(42, $folder->getId()); + $this->assertSame(0, $folder->getQuota()); } public function testUnlinkKeepsFolderAndClearsTeamLink(): void {