From 72ef9591ea3f0bc1e7615cf111dcaebbf7cd8d21 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gilles=20Qu=C3=A9not?= <gq@sputnick.fr>
Date: Tue, 12 Nov 2024 22:30:59 +0700
Subject: [PATCH 1/4] Add context and code to install profiler
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Gilles Quénot <gq@sputnick.fr>
---
 developer_manual/digging_deeper/profiler.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/developer_manual/digging_deeper/profiler.rst b/developer_manual/digging_deeper/profiler.rst
index 7a0d4b0b007..b6222c059f0 100644
--- a/developer_manual/digging_deeper/profiler.rst
+++ b/developer_manual/digging_deeper/profiler.rst
@@ -23,6 +23,10 @@ To enable the app, you can run the following commands:
 
 .. code-block:: bash
 
+   cd apps/
+   git clone https://github.com/nextcloud/profiler.git
+   git checkout stable30 # adapt to your version: php occ version |& grep -oP 'Nextcloud \K\d+'
+   cd ..
    npm ci && npm run build
    occ app:enable profiler
    occ profiler:enable # This will also enable the debug mode if not already enabled

From 5dea5e7e6f80249cda4ab94833b0982f78d2000a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gilles=20Qu=C3=A9not?= <gq@sputnick.fr>
Date: Wed, 13 Nov 2024 09:01:38 +0700
Subject: [PATCH 2/4] Add missing 'cd'
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Gilles Quénot <gq@sputnick.fr>
---
 developer_manual/digging_deeper/profiler.rst | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/developer_manual/digging_deeper/profiler.rst b/developer_manual/digging_deeper/profiler.rst
index b6222c059f0..d9db9bf1b2f 100644
--- a/developer_manual/digging_deeper/profiler.rst
+++ b/developer_manual/digging_deeper/profiler.rst
@@ -25,8 +25,9 @@ To enable the app, you can run the following commands:
 
    cd apps/
    git clone https://github.com/nextcloud/profiler.git
+   cd profiler
    git checkout stable30 # adapt to your version: php occ version |& grep -oP 'Nextcloud \K\d+'
-   cd ..
+   cd ../..
    npm ci && npm run build
    occ app:enable profiler
    occ profiler:enable # This will also enable the debug mode if not already enabled

From 87f84d6a6895cdb23eeb73c1b582ae07ca585ac9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gilles=20Qu=C3=A9not?= <gq@sputnick.fr>
Date: Wed, 13 Nov 2024 09:07:12 +0700
Subject: [PATCH 3/4] Implement @susnux recommendations from review
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

 - move the code to 'get the app' section
 - s/stable30/stableX

Signed-off-by: Gilles Quénot <gq@sputnick.fr>
---
 developer_manual/digging_deeper/profiler.rst | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/developer_manual/digging_deeper/profiler.rst b/developer_manual/digging_deeper/profiler.rst
index d9db9bf1b2f..c8a0a51365d 100644
--- a/developer_manual/digging_deeper/profiler.rst
+++ b/developer_manual/digging_deeper/profiler.rst
@@ -11,6 +11,15 @@ The profiler application is available on `GitHub <https://github.com/nextcloud/p
 you need to clone the stableX branch if you are using Nextcloud X or master if you are
 using the latest development version of Nextcloud.
 
+.. code-block:: bash
+
+   cd apps/
+   git clone https://github.com/nextcloud/profiler.git
+   cd profiler
+   git checkout stableX # adapt X to your version: php occ version |& grep -oP 'Nextcloud \K\d+'
+   cd ../..
+
+
 Enable the app
 --------------
 
@@ -23,11 +32,6 @@ To enable the app, you can run the following commands:
 
 .. code-block:: bash
 
-   cd apps/
-   git clone https://github.com/nextcloud/profiler.git
-   cd profiler
-   git checkout stable30 # adapt to your version: php occ version |& grep -oP 'Nextcloud \K\d+'
-   cd ../..
    npm ci && npm run build
    occ app:enable profiler
    occ profiler:enable # This will also enable the debug mode if not already enabled

From 394b0a72aa2a5f06ea0cd0caf26a8beca3ef1f63 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gilles=20Qu=C3=A9not?= <gq@sputnick.fr>
Date: Wed, 13 Nov 2024 14:05:03 +0700
Subject: [PATCH 4/4] Update developer_manual/digging_deeper/profiler.rst
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Gilles Quénot <gq@sputnick.fr>
---
 developer_manual/digging_deeper/profiler.rst | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/developer_manual/digging_deeper/profiler.rst b/developer_manual/digging_deeper/profiler.rst
index c8a0a51365d..9da9af0d7af 100644
--- a/developer_manual/digging_deeper/profiler.rst
+++ b/developer_manual/digging_deeper/profiler.rst
@@ -14,9 +14,9 @@ using the latest development version of Nextcloud.
 .. code-block:: bash
 
    cd apps/
-   git clone https://github.com/nextcloud/profiler.git
+   git clone --branch stableX https://github.com/nextcloud/profiler.git
+   # adapt X to your Nextcloud version: php occ version | grep -oP 'Nextcloud \K\d+'
    cd profiler
-   git checkout stableX # adapt X to your version: php occ version |& grep -oP 'Nextcloud \K\d+'
    cd ../..