From 917bd5c7099a2f0d8eb3e69f915e5c7e3d0aba45 Mon Sep 17 00:00:00 2001 From: Rikdekker Date: Fri, 28 Aug 2026 11:17:13 +0200 Subject: [PATCH 1/2] fix(resources): align the room filter select with the text field next to it MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Features select renders 2px taller than the Minimum capacity text field beside it, so the two controls in the filter row do not line up. NcSelect sets `padding: var(--border-width-input)` on `.vs__dropdown-toggle`. That padding stacks on top of the `min-height: var(--default-clickable-area)` the toggle already carries, so the select ends up at 36px where the text field sits at 34px. `min-height` is a floor, not a ceiling, and cannot hold the padding back. Measured on Nextcloud 34 with calendar 6.6.0-rc.1: | control | before | after | |--------------------------------|--------|-------| | NcTextField (Minimum capacity) | 34px | 34px | | NcSelect (Features) | 36px | 34px | NcSelect already drops the padding to 0 in its open state, so clearing it here does not make the control jump when the dropdown opens — verified by measuring the closed and open states side by side, both 34px. Signed-off-by: Rik Dekker --- src/components/Editor/Resources/RoomSelectionModal.vue | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/components/Editor/Resources/RoomSelectionModal.vue b/src/components/Editor/Resources/RoomSelectionModal.vue index 7756748a99..9fb34d1e53 100644 --- a/src/components/Editor/Resources/RoomSelectionModal.vue +++ b/src/components/Editor/Resources/RoomSelectionModal.vue @@ -448,8 +448,13 @@ watch( margin: 0; } + // NcSelect pads the toggle by --border-width-input on every side, which + // stacks on top of the min-height and makes the select 2px taller than + // the text field next to it. The padding is dropped in the open state + // anyway, so clearing it here keeps both controls at the same height. :deep(.v-select.select .vs__dropdown-toggle) { min-height: var(--default-clickable-area); + padding: 0; } // While the dropdown is closed there is nothing to type into, so the From ce5a6165785543327fc2c685611c943a766a0e08 Mon Sep 17 00:00:00 2001 From: Rikdekker Date: Fri, 28 Aug 2026 11:24:53 +0200 Subject: [PATCH 2/2] fix(resources): let the room filter labels use the default font size Signed-off-by: Rik Dekker --- src/components/Editor/Resources/RoomSelectionModal.vue | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/components/Editor/Resources/RoomSelectionModal.vue b/src/components/Editor/Resources/RoomSelectionModal.vue index 9fb34d1e53..5b79b728c4 100644 --- a/src/components/Editor/Resources/RoomSelectionModal.vue +++ b/src/components/Editor/Resources/RoomSelectionModal.vue @@ -436,7 +436,6 @@ watch( &__label { color: var(--color-text-maxcontrast); - font-size: calc(var(--default-font-size) * 0.9); } // Give every control the same height and let the row decide the width @@ -448,10 +447,7 @@ watch( margin: 0; } - // NcSelect pads the toggle by --border-width-input on every side, which - // stacks on top of the min-height and makes the select 2px taller than - // the text field next to it. The padding is dropped in the open state - // anyway, so clearing it here keeps both controls at the same height. + // NcSelect pads the toggle by --border-width-input on every side :deep(.v-select.select .vs__dropdown-toggle) { min-height: var(--default-clickable-area); padding: 0;