Skip to content

Commit 5413885

Browse files
Merge pull request #17666 from nextcloud/backport/17663/stable-35.0.x
[stable-35.0.x] fix(recommended-file): padding
2 parents 062b7ae + 053c205 commit 5413885

2 files changed

Lines changed: 11 additions & 9 deletions

File tree

app/src/main/res/layout/recommended_file_item.xml

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -50,10 +50,10 @@
5050
android:padding="@dimen/standard_quarter_padding"
5151
android:translationZ="4dp"
5252
app:layout_constraintBottom_toBottomOf="@+id/thumbnail"
53-
app:layout_constraintEnd_toEndOf="parent"
53+
app:layout_constraintEnd_toEndOf="@+id/thumbnail"
5454
app:layout_constraintHorizontal_bias="0.85"
55-
app:layout_constraintStart_toStartOf="parent"
56-
app:layout_constraintTop_toTopOf="parent"
55+
app:layout_constraintStart_toStartOf="@+id/thumbnail"
56+
app:layout_constraintTop_toTopOf="@+id/thumbnail"
5757
app:layout_constraintVertical_bias="0.85">
5858

5959
<ImageView
@@ -134,17 +134,18 @@
134134
android:layout_marginTop="@dimen/grid_checkbox_margin"
135135
android:contentDescription="@string/checkbox"
136136
android:src="@android:drawable/checkbox_off_background"
137-
app:layout_constraintStart_toStartOf="parent"
138-
app:layout_constraintTop_toTopOf="parent"
137+
app:layout_constraintStart_toStartOf="@+id/thumbnail"
138+
app:layout_constraintTop_toTopOf="@+id/thumbnail"
139139
tools:visibility="visible" />
140140

141141
<LinearLayout
142142
android:id="@+id/filename_and_reason_layout"
143143
android:layout_width="0dp"
144144
android:layout_height="wrap_content"
145+
android:layout_marginHorizontal="@dimen/grid_recommended_item_text_horizontal_margin"
145146
android:gravity="center"
146-
app:layout_constraintEnd_toStartOf="@+id/more"
147147
app:layout_constraintBottom_toBottomOf="parent"
148+
app:layout_constraintEnd_toEndOf="parent"
148149
app:layout_constraintStart_toStartOf="parent"
149150
app:layout_constraintTop_toBottomOf="@+id/thumbnail"
150151
android:orientation="vertical">
@@ -213,10 +214,10 @@
213214
android:id="@+id/more"
214215
android:layout_width="@dimen/grid_bottom_view_height"
215216
android:layout_height="@dimen/grid_bottom_view_height"
216-
android:layout_marginHorizontal="@dimen/standard_half_margin"
217+
android:layout_marginEnd="@dimen/standard_half_margin"
217218
android:contentDescription="@string/overflow_menu"
218-
app:layout_constraintBottom_toBottomOf="parent"
219-
app:layout_constraintTop_toBottomOf="@+id/thumbnail"
219+
app:layout_constraintBottom_toBottomOf="@+id/filename_and_reason_layout"
220+
app:layout_constraintTop_toTopOf="@+id/filename_and_reason_layout"
220221
app:layout_constraintEnd_toEndOf="parent"
221222
app:srcCompat="@drawable/ic_dots_vertical"
222223
android:background="?android:attr/selectableItemBackgroundBorderless"

app/src/main/res/values/dims.xml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
<dimen name="grid_checkbox_size">18dp</dimen>
5959
<dimen name="grid_checkbox_margin">6dp</dimen>
6060
<dimen name="grid_recommended_file_container_width">160dp</dimen>
61+
<dimen name="grid_recommended_item_text_horizontal_margin">28dp</dimen>
6162
<dimen name="grid_container_default_max_file_name">80dp</dimen>
6263

6364
<dimen name="album_container_height">300dp</dimen>

0 commit comments

Comments
 (0)