diff --git a/php/domain-validator.php b/php/domain-validator.php index a1e6487be6c9..8f4fca11dd96 100644 --- a/php/domain-validator.php +++ b/php/domain-validator.php @@ -8,7 +8,7 @@ http_response_code(400); } elseif (strpos($domain, ':') !== false) { http_response_code(400); -} elseif (!filter_var($domain, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME)) { +} elseif (!filter_var($domain, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME) === false) { http_response_code(400); } elseif (filter_var($domain, FILTER_VALIDATE_IP)) { http_response_code(400); diff --git a/php/psalm-baseline.xml b/php/psalm-baseline.xml index efff05605cea..19d94ff7c22b 100644 --- a/php/psalm-baseline.xml +++ b/php/psalm-baseline.xml @@ -1,2 +1,2 @@ <?xml version="1.0" encoding="UTF-8"?> -<files psalm-version="5.19.0@06b71be009a6bd6d81b9811855d6629b9fe90e1b"/> +<files psalm-version="5.20.0@3f284e96c9d9be6fe6b15c79416e1d1903dcfef4"/> diff --git a/php/src/Data/ConfigurationManager.php b/php/src/Data/ConfigurationManager.php index 51780b35be25..3b3cba5db21f 100644 --- a/php/src/Data/ConfigurationManager.php +++ b/php/src/Data/ConfigurationManager.php @@ -286,7 +286,7 @@ public function SetDomain(string $domain) : void { } // Validate domain - if (!filter_var($domain, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME)) { + if (filter_var($domain, FILTER_VALIDATE_DOMAIN, FILTER_FLAG_HOSTNAME) === false) { throw new InvalidSettingConfigurationException("Domain is not a valid domain!"); } @@ -305,7 +305,7 @@ public function SetDomain(string $domain) : void { if (empty($dnsRecordIP)) { $record = dns_get_record($domain, DNS_AAAA); - if (!empty($record)) { + if (!empty($record[0]['ipv6'])) { $dnsRecordIP = $record[0]['ipv6']; } }