test: 테스트 코드 내 매직 넘버 상수로 대체

Author: chemistryx

src/main/java/io/suhan/racingcar/domain/Car.java

@@ -4,8 +4,8 @@
 import io.suhan.racingcar.generator.RandomNumberGenerator;
 
 public class Car {
-    private static final int CAR_MOVE_THRESHOLD = 4;
-    private static final int CAR_NAME_MAXIMUM_LENGTH = 5;
+    public static final int CAR_MOVE_THRESHOLD = 4;
+    public static final int CAR_NAME_MAXIMUM_LENGTH = 5;
 
     private final String name;
     private final NumberGenerator generator;

src/test/java/io/suhan/racingcar/domain/CarTest.java

@@ -1,5 +1,6 @@
 package io.suhan.racingcar.domain;
 
+import static io.suhan.racingcar.domain.Car.CAR_MOVE_THRESHOLD;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertNotEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
@@ -23,7 +24,7 @@ public class CarTest {
 
     @Test
     void 생성된_값이_4_이상일_경우_자동차가_움직일_수_있다() {
-        FixedNumberGenerator generator = new FixedNumberGenerator(4);
+        FixedNumberGenerator generator = new FixedNumberGenerator(CAR_MOVE_THRESHOLD);
         Car car = Car.of("neo", generator);
 
         car.move();
@@ -35,7 +36,7 @@ public class CarTest {
 
     @Test
     void 생성된_값이_3_이하일_경우_자동차가_멈춘다() {
-        FixedNumberGenerator generator = new FixedNumberGenerator(3);
+        FixedNumberGenerator generator = new FixedNumberGenerator(CAR_MOVE_THRESHOLD - 1);
         Car car = Car.of("neo", generator);
 
         car.move();

src/test/java/io/suhan/racingcar/domain/GameTest.java

@@ -1,5 +1,6 @@
 package io.suhan.racingcar.domain;
 
+import static io.suhan.racingcar.domain.Car.CAR_MOVE_THRESHOLD;
 import static org.junit.jupiter.api.Assertions.assertIterableEquals;
 import static org.junit.jupiter.api.Assertions.assertThrows;
 
@@ -30,8 +31,8 @@ public class GameTest {
         // given
         Game game = Game.of(5);
 
-        FixedNumberGenerator forwardGenerator = new FixedNumberGenerator(4);
-        FixedNumberGenerator stopGenerator = new FixedNumberGenerator(3);
+        FixedNumberGenerator forwardGenerator = new FixedNumberGenerator(CAR_MOVE_THRESHOLD);
+        FixedNumberGenerator stopGenerator = new FixedNumberGenerator(CAR_MOVE_THRESHOLD - 1);
 
         Car neo = Car.of("neo", forwardGenerator);
         Car brie = Car.of("brie", stopGenerator);