Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LogglyClient documentation suggestion #113

Open
alexsaare opened this issue Dec 15, 2020 · 0 comments
Open

LogglyClient documentation suggestion #113

alexsaare opened this issue Dec 15, 2020 · 0 comments

Comments

@alexsaare
Copy link

Just a suggestion for the documentation in the readme - please correct me if i'm wrong.

From looking at the code for LogglyClient it would make sense for it to be stored and used as a singleton - especially when using Https transport in a web application environment. The default constructor uses the TransportFactory method which returns a new instance of HttpMessageTransport. This in turn creates a new HttpClient which (as per the official documents) is "intended to be instantiated once and reused throughout the life of an application"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant