Skip to content

Commit 06d46a1

Browse files
committed
Fix release staging for windows
Motivation: 191f5ae did made chances on how the artifacts are named but missed to adjust the staging workflow for windows which did cause the release to not include artifacts for windows anymore Modifications: Ensure we refer to the correct path all the time Result: Correctly release artifacts for windows again as well
1 parent 4e4f4ed commit 06d46a1

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

.github/workflows/ci-release.yml

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ jobs:
177177
uses: actions/download-artifact@v2
178178
with:
179179
name: prepare-release-workspace
180-
path: prepare-release-workspace
180+
path: ${{ github.workspace }}/prepare-release-workspace
181181

182182
- name: Setup git configuration
183183
run: |
@@ -241,18 +241,20 @@ jobs:
241241
}]
242242
243243
- name: Stage release to local staging directory
244-
working-directory: prepare-release-workspace
245-
run: ./mvnw.cmd -B -ntp --file pom.xml clean javadoc:jar package gpg:sign org.sonatype.plugins:nexus-staging-maven-plugin:deploy -DnexusUrl=https://oss.sonatype.org -DserverId=sonatype-nexus-staging -DaltStagingDirectory=local-staging -DskipRemoteStaging=true -DskipTests=true -D'checkstyle.skip=true'
244+
working-directory: ${{ github.workspace }}/prepare-release-workspace
245+
env:
246+
LOCAL_STAGING_DIR: ${{ github.workspace }}/prepare-release-workspace/local-staging
247+
run: ./mvnw.cmd -B -ntp --file pom.xml clean javadoc:jar package gpg:sign org.sonatype.plugins:nexus-staging-maven-plugin:deploy -DnexusUrl=https://oss.sonatype.org -DserverId=sonatype-nexus-staging -DaltStagingDirectory=D:\a\netty-incubator-codec-quic\netty-incubator-codec-quic\prepare-release-workspace\local-staging -DskipRemoteStaging=true -DskipTests=true -D'checkstyle.skip=true'
246248

247249
- name: Upload local staging directory
248250
uses: actions/upload-artifact@v2
249251
with:
250252
name: windows-x86_64-local-staging
251-
path: prepare-release-workspace/local-staging
253+
path: ${{ github.workspace }}/prepare-release-workspace/local-staging
252254
if-no-files-found: error
253255

254256
- name: Rollback release on failure
255-
working-directory: prepare-release-workspace
257+
working-directory: ${{ github.workspace }}/prepare-release-workspace
256258
if: ${{ failure() }}
257259
# Rollback the release in case of an failure
258260
run: ./.github/scripts/release_rollback.ps1 release.properties netty/netty-incubator-codec-quic main

0 commit comments

Comments
 (0)