Skip to content

Conversation

@bonktree
Copy link
Contributor

@bonktree bonktree commented Sep 4, 2025

https://support.huawei.com/enterprise/en/doc/EDOC1000019246/fcf3265f/fan-040a-series-fan-modules

These can be installed in CE5855-48T4S2Q-EI, CE5855-24T4S2Q-EI.

@bonktree
Copy link
Contributor Author

bonktree commented Sep 4, 2025

Failed: module-types/Huawei/FAN-040A-B.yaml failed validation: Additional properties are not allowed ('airflow' was unexpected)

Failed: module-types/Huawei/FAN-040A-F.yaml failed validation: Additional properties are not allowed ('airflow' was unexpected)

That is unfortunate.
The chassis does not enforce an air flow direction, it is determined by the installed fan modules only. So an absent airflow field for the switch would make sense, if fan modules would have their own airflow.
Removing.

@bonktree bonktree marked this pull request as ready for review September 4, 2025 10:43
@harryajc
Copy link
Collaborator

harryajc commented Sep 4, 2025

Failed: module-types/Huawei/FAN-040A-B.yaml failed validation: Additional properties are not allowed ('airflow' was unexpected)

Failed: module-types/Huawei/FAN-040A-F.yaml failed validation: Additional properties are not allowed ('airflow' was unexpected)

That is unfortunate. The chassis does not enforce an air flow direction, it is determined by the installed fan modules only. So an absent airflow field for the switch would make sense, if fan modules would have their own airflow. Removing.

If you want to add support for airflow, like what was suggested under #3364 then that would be accepted as the issue with that PR is to do with the profile implementation

@bonktree
Copy link
Contributor Author

bonktree commented Sep 4, 2025

The chassis does not enforce an air flow direction, it is determined by the installed fan modules only. So an absent airflow field for the switch would make sense, if fan modules would have their own airflow. Removing.

If you want to add support for airflow, like what was suggested under #3364 then that would be accepted as the issue with that PR is to do with the profile implementation

@harryajc, that would be great. I've submitted a PR to address that.

@harryajc
Copy link
Collaborator

harryajc commented Sep 4, 2025

I have merged that PR so you should be able to add the airflow property now

@harryajc harryajc merged commit ef48159 into netbox-community:master Sep 4, 2025
3 checks passed
@bonktree bonktree deleted the huawei-fan-040a branch September 4, 2025 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants