Skip to content

Conversation

@vowaof
Copy link

@vowaof vowaof commented Nov 24, 2025

Describe your changes

When recreating the infrastructure artifacts files using the configure.sh script, it searches for the DataStoreEncryptionKey in the management.json file.

The problem is, that it searches for the file in the folder infrastructure_files and not in the correct $artifacts_path folder.

Thats why the DataStoreEncryptionKey gets cleared and newly generated every time the configure.sh script is executed.

This PR fixes the problem by using the correct path for the reading of the DataStoreEncryptionKey from $artifacts_path/management.json

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs not needed explanation

It's a bugfix in the infrastructure configure.sh script which doesn't change the way it's used.

Summary by CodeRabbit

  • Chores
    • Updated configuration file path resolution to use artifact directory structure.

✏️ Tip: You can customize this high-level summary in your review settings.

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2025

CLA assistant check
All committers have signed the CLA.

@sonarqubecloud
Copy link

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 24, 2025

Walkthrough

A bash configuration script is updated to reference management.json from an artifacts directory path instead of the local directory, ensuring the file check and jq read operation consistently use the correct path.

Changes

Cohort / File(s) Summary
Path Reference Update
infrastructure_files/configure.sh
Updated file path references from management.json to ${artifacts_path}/management.json in both the file existence check and jq invocation, while preserving downstream logic for exporting the encryption key.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5–10 minutes

  • Verify that ${artifacts_path} is properly defined and available in the script context
  • Confirm that the path change aligns with the intended artifact storage structure
  • Ensure no other references to management.json in the script require similar updates

Poem

🐰 A path adjustment, clean and bright,
From local files to artifacts' light,
The rabbit hops with config in hand,
Finding management.json in the right land! 🌟

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: fixing the management.json path in configure.sh when recreating artifact files.
Description check ✅ Passed The description includes a clear explanation of the bug, its impact, and the fix. The required checklist is completed with bug fix selected, and documentation necessity is properly addressed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 131d7a3 and f4fbc3e.

📒 Files selected for processing (1)
  • infrastructure_files/configure.sh (1 hunks)
🔇 Additional comments (1)
infrastructure_files/configure.sh (1)

237-242: Fix correctly addresses the path issue.

The change properly reads DataStoreEncryptionKey from the correct ${artifacts_path}/management.json location instead of the local directory. This aligns with the rest of the script's file handling (lines 247–260) and ensures the encryption key is preserved across runs without unnecessary regeneration.

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

  • Provide your own instructions using the high_level_summary_instructions setting.
  • Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
  • Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

  1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
  2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
  3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
  4. 📊 Contributor Summary — Include a Markdown table showing contributions:
    | Contributor | Lines Added | Lines Removed | Files Changed |
  5. ✔️ Additional Notes — Add any extra reviewer context.
    Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants