Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement for ship workflow #5

Open
muuvmuuv opened this issue Dec 3, 2020 · 0 comments
Open

Improvement for ship workflow #5

muuvmuuv opened this issue Dec 3, 2020 · 0 comments

Comments

@muuvmuuv
Copy link

muuvmuuv commented Dec 3, 2020

I think it does make more sense to run the ship workflow only after a release has been created, so I modified mine to the below. Maybe this should be added here to for some folks that wants the same instead of ship on every tag creation.

on:
  release:
    types:
      - published

A release workflow will previously run deno lint, deno test and then release a new version based on a tag that has been created.

https://github.com/m8finder/webssl/tree/main/.github/workflows

NOTE: using the default repository GITHUB_TOKEN for a release will not trigger any on.release.types.* during a CI workflow run. For this it is needed to use a personal access token. Read: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#triggering-new-workflows-using-a-personal-access-token

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant