Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more colors (and a few other suggestions) #1

Open
b0o opened this issue Nov 29, 2023 · 1 comment
Open

Support more colors (and a few other suggestions) #1

b0o opened this issue Nov 29, 2023 · 1 comment

Comments

@b0o
Copy link

b0o commented Nov 29, 2023

First, I really like this plugin. Nice work!

I did notice this line in the README:

easycolor.nvim does provide a more limited selection of colors than other plugins. This plugin is designed for those who don't need access to all 16.8 million colors, and instead prefer ease of use over fine-grained selection.

BUT, I still can't help but want more colors. I had a few ideas...

  1. Make the grid size and number of hues configurable
  2. Similar to how ccc.nvim works, allow moving in smaller increments than the UI displays (try out that plugin to see what I mean)
  3. Support tweaking the RGB/HSV values 1 increment up/down (maybe support tab to navigate the arrow between the hue selection and R/G/B/H/S/V and then up/down arrows to adjust)
  4. Weird idea: support "zooming in" to the cursor's location in the grid

Also a few other things I noticed:

  1. If :EasyColor is run while the cursor is over a color code, start EasyColor with that color and replace it on insertion
  2. Based on the color under the cursor, change the cursor color to black if the contrast would be better
  3. Mouse support would be cool
@neph-iap
Copy link
Owner

Thanks for your feedback!

  1. Configuring the grid size and number of hues is an interesting idea. I don't see this as necessarily super high priority or important but it could be neat and I'll keep it in mind. It would definitely be a tough change because of how I'm drawing the UI, but definitely doable.

2/3. Originally I had planned to make the HSV and RGB sliders on the right moveable for more fine-grained selection. However, I found that the colors on the grid are close enough to each other that it wasn't really needed; In fact I am strongly considering removing the right side of the window entirely to clear up visual clutter (I would keep the template and result, but just move those onto the left half and get rid of the RGB/HSV sliders. The only aspect that I felt could use more fine-grained selection is the hue, and something like moving in increments smaller than the UI allows would be a nice enhancement.

  1. I'm not going to say this is impossible, but it would be really difficult for something that I don't personally find overly necessary; Adjacent colors on the grid are close enough for 99% of use cases. This plugin is designed for those projects that don't need to distinguish between two colors that are only off by a couple hex digits; The difference is barely noticeable for most use cases.

As for your other points,

  1. This isn't a bad idea, but easycolor.nvim allows inserting colors in different formats. This would be simple for hex colors, but colors that have different formats and might be more separated could be difficult to detect.

  2. This is definitely something that I should do and at one point did have planned, good note.

  3. I haven't ever used a mouse in Neovim, so I have no idea how this functionality would be implemented or used. This likely won't happen but could be something way down the line if I feel there's not much else to add to the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants