Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packspec vs specification_version #38

Open
gwww opened this issue Apr 17, 2022 · 2 comments
Open

packspec vs specification_version #38

gwww opened this issue Apr 17, 2022 · 2 comments

Comments

@gwww
Copy link

gwww commented Apr 17, 2022

The field descriptions use packspec as the keyword in the schema. The examples use specification_version.

My 2 cents is I dislike specification_version as not being intent specific enough. I prefer packspec but would prefer something even more descriptive. packspec_schema_version is one suggestion.

@mjlbach
Copy link
Contributor

mjlbach commented Apr 17, 2022

packspec_version?

@ii14
Copy link
Member

ii14 commented Apr 18, 2022

My 2 cents is I dislike specification_version as not being intent specific enough. I prefer packspec but would prefer something even more descriptive.

Examples were not updated, the schema is actually correct here, it supposed to be just packspec.

I personally like just packspec more. On top of declaring the actual specification version, the presence of the field itself can serve the purpose of "magic bytes", signifying that this is supposed to be a packspec file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants