Merge pull request #246 from s1ck/snow-22-use-from_snowflake-in-experimentalvisualize

Drop table property key after caption assignment

Author: s1ck

changelog.md

@@ -2,6 +2,7 @@
 
 ## Breaking changes
 
+* Removed `table` property from nodes and relationships returned from `from_snowflake`, the table is represented by the `caption` field.
 
 ## New features
 

python-wrapper/src/neo4j_viz/snowflake.py

@@ -341,9 +341,9 @@ def from_snowflake(
     VG = from_dfs(node_dfs, rel_dfs)
 
     for node in VG.nodes:
-        node.caption = node.properties.get("table")
+        node.caption = node.properties.pop("table")
     for rel in VG.relationships:
-        rel.caption = rel.properties.get("table")
+        rel.caption = rel.properties.pop("table")
 
     number_of_colors = node_df["table"].drop_duplicates().count()
     if number_of_colors <= len(NEO4J_COLORS_DISCRETE):

python-wrapper/tests/test_snowflake.py

@@ -60,13 +60,13 @@ def test_from_snowflake(session_with_minimal_graph: Session) -> None:
     )
 
     assert VG.nodes == [
-        Node(id=0, caption="NODES", color="#ffdf81", properties={"SNOWFLAKEID": 6, "table": "NODES"}),
-        Node(id=1, caption="NODES", color="#ffdf81", properties={"SNOWFLAKEID": 7, "table": "NODES"}),
+        Node(id=0, caption="NODES", color="#ffdf81", properties={"SNOWFLAKEID": 6}),
+        Node(id=1, caption="NODES", color="#ffdf81", properties={"SNOWFLAKEID": 7}),
     ]
 
     assert len(VG.relationships) == 1
 
     assert VG.relationships[0].source == 0
     assert VG.relationships[0].target == 1
     assert VG.relationships[0].caption == "RELS"
-    assert VG.relationships[0].properties == {"table": "RELS"}
+    assert VG.relationships[0].properties == {}