fix(acquisition): avoid infinite connection timeout if there is a limit (#1689)

As acquisition timeout effectively includes connection timeout, the latter should not be left infinite when the former is limited.

Author: injectives

driver/src/main/java/org/neo4j/driver/internal/DriverFactory.java

@@ -366,6 +366,15 @@ private BoltConnectionSourceFactory createPooledBoltConnectionSource(
                     boltConnectionProviderFactory);
             var listeningBoltConnectionProvider = BoltConnectionListener.listeningBoltConnectionProvider(
                     boltConnectionProvider, boltConnectionListener);
+            var connectTimeoutMillisAdjusted = connectTimeoutMillis;
+            var connectionAcquisitionTimeoutMillis = config.connectionAcquisitionTimeoutMillis();
+            if (connectTimeoutMillisAdjusted == 0 && connectionAcquisitionTimeoutMillis > 0) {
+                connectTimeoutMillisAdjusted = (int) connectionAcquisitionTimeoutMillis;
+                if (connectTimeoutMillisAdjusted != connectionAcquisitionTimeoutMillis) {
+                    throw new IllegalStateException(
+                            "Failed to determine connection timeout from acquisition timeout due to overflow, set connection timeout to non zero value");
+                }
+            }
             return new PooledBoltConnectionSource(
                     loggingProvider,
                     clock,
@@ -374,14 +383,14 @@ private BoltConnectionSourceFactory createPooledBoltConnectionSource(
                     authTokenManager,
                     createSecurityPlanSupplierWithHostname(securityPlanSupplier, expectedVerificationHostname),
                     config.maxConnectionPoolSize(),
-                    config.connectionAcquisitionTimeoutMillis(),
+                    connectionAcquisitionTimeoutMillis,
                     config.maxConnectionLifetimeMillis(),
                     config.idleTimeBeforeConnectionTest(),
                     observationProvider,
                     routingContextAddress,
                     boltAgent,
                     userAgent,
-                    connectTimeoutMillis,
+                    connectTimeoutMillisAdjusted,
                     notificationConfig,
                     PooledBoltConnectionSource.TimeoutPolicy.DEFAULT);
         };