-
Notifications
You must be signed in to change notification settings - Fork 1k
Exec Factor with decimals #4202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
roman-khimov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner now. But I'd also adjust BurnGas() since it's documented to use datoshis and for its users (if there are any) that should be sufficient.
|
I think it could be more clear if we multiply inside AddFee method, otherwise, AddFee it's in picoDatoshi and BurnFee it's in datoshi, what do you think @roman-khimov @AnnaShaleva? |
|
AddFee is an internal thing, BurnFee is only used by contracts. To me it's not a problem. |
|
Please @neo-project/core review this PR, as we agree in Centre Point it's important for the community. Important changes areas:
|
picoGAS! It's 8+4, so 1^-12. picoDatoshi would be 1^-20. |
|
The The |
…t/neo into exec-fee-two-decimals
|
Thanks @superboyiii ! please check it again, it should be fixed |
should not be changed outside the |
AnnaShaleva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me check it with NeoGo implementation.
Co-authored-by: Anna Shaleva <[email protected]>
|
I tried some blocks, no incompatible data found. Let me make a full sync to check all. |
|
Storage is compatible now. |
Co-authored-by: Anna Shaleva <[email protected]>
|
Closed in favor of #4278
|
Description
Please @neo-project/core review this PR, as we agree in Centre Point it's important for the community.
Was decided in Centre Point to have two decimals in
ExecutionFactorthis PR tries to address itType of change
How Has This Been Tested?
Test Configuration:
Checklist: