count number 1D-2D connections in a calculation cell

[caspervdw]

@Jonasvsl commented on Mon Oct 24 2022

---

@Jonasvsl commented on Mon Oct 24 2022

not sure if this can be in the checker but we need to have a warning in case there are more than X 1D-2D connections in the same computational cell.

Let's discuss with Nici what would be a treshold value

[Jonasvsl]

As discussed with Casper, it is very difficult to make this part of the checker, but we can make this part of the grid builder.

Here's a thought: Why don't we include creating the computational grid in the workflow for the users before uploading the schematisation?

Perhaps even create a workflow with checks and computational grid schematisation and one without for those that feel lucky?
@leendertvanwolfswinkel What are your thoughts on this?

[leendertvanwolfswinkel]

I think it is an excellent idea. Very similar to how the schematisation checker is part of the upload wizard. We have just removed the raster checker; in its place we could generate the computational grid and show any errors & warnings from that process in a table.

Would be helpful if threedigrid_builder outputs errors and warnings in a similar way as threedi_modelchecker

[leendertvanwolfswinkel]

nens/threedi-api-qgis-client#429

[elisalle]

@leendertvanwolfswinkel this ticket appears to consist of two parts:

• handle logs (warnings, errors) from threedi-gridbuilder in the qgis plugin and present them to the user, as is done with the modelchecker
• generate a warning for a number of 1D-2D connections in a calculation cell greater than a certain value

Casper suggests that maybe you could open a separate ticket for the first part?

[elisalle]

@nvolp could you supply a threshold for a maximum value for the 1D-2D connections in a calculation cell?

[leendertvanwolfswinkel]

@elisallenens yes I already made that ticket and referred to it in a comment 👍 nens/threedi-api-qgis-client#429

[elisalle]

Discussed this with Martijn Siemerink, and this ticket appears to be a whole new feature, not just a simple check. That makes it a little too big for me to pick up right now.