Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement generating embeddable icons link tags #5

Open
neg4n opened this issue Sep 4, 2021 · 2 comments
Open

Implement generating embeddable icons link tags #5

neg4n opened this issue Sep 4, 2021 · 2 comments
Assignees
Labels
feature New feature or request package:cli Related to faviconize-cli package package:library Related to faviconize package

Comments

@neg4n
Copy link
Owner

neg4n commented Sep 4, 2021

It would be nice to have ability to generate embeddable, ready to paste into
HTML document link tags. Also generating manifest files for msapplication icons
would be nice too.

In the CLI - how should we handle such generating?
Should we copy it to clipboard or output it to file?

@neg4n neg4n added feature New feature or request package:cli Related to faviconize-cli package package:library Related to faviconize package labels Sep 4, 2021
@neg4n neg4n self-assigned this Sep 4, 2021
@neg4n
Copy link
Owner Author

neg4n commented Sep 7, 2021

According to the Microsoft docs, is generating multiple msApplicationTileImages necessary?

Currently, the icon types and edges constants looks like this:

export const iconTypesAndEdgesMap: IconTypeAndEdges = {
  icon: [196, 160, 96, 32, 16],
  'msapplication-TileImage': [70, 150, 310],
  'apple-touch-icon': [57, 144, 72, 144, 60, 120, 76, 152],
}

It seems that these values are not 1:1 valid with the docs.
Also, they seem to be generated in wrong format. Correct one can be found in this section of Microsoft docs.

The another things is fact, that browserconfig.xml (its generation is not even implemented yet) can be fully replaced by meta tags in HTML document.

The previous example shows how to create a browser config file to declare images and polling URIs, but you can also put metadata into the head element of your HTML page [...]

These problems and questions should be resolved and answered in near future...

@neg4n
Copy link
Owner Author

neg4n commented Sep 11, 2021

It seems that link tags generation is now implemented in the faviconize (library).

Sorting those tags by type (order tbd) and ascending edge values would be nice although this is rather nice-to-have feature than 'must-be-implemented-asap'. Will make another issue for it when link tags generation will get merged into main and published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request package:cli Related to faviconize-cli package package:library Related to faviconize package
Projects
None yet
Development

No branches or pull requests

1 participant