Fix updating global locks with updateDependencies set #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aughr
force-pushed
the
fix_updating_global_locks
branch
2 times, most recently
from
3eac7b2 to
7e7741e
Compare
Contributor
Author
|
Updated to scope the change in behavior to global locks only. |
Contributor
Author
|
@quidryan Does this look reasonable? Sorry to explicitly tag you, but you did touch this repo a couple of days ago 😅 |
Contributor
Author
|
@rspieldenner @nadavc Does this look OK to you? |
Because dependencies are "transitive" in the global context, we need to ensure that anything a project directly depends on is not excluded from the list of forces.
aughr
force-pushed
the
fix_updating_global_locks
branch
from
7e7741e to
2b37699
Compare
Contributor
Author
|
@DanielThomas Rebased on master, all green again. |
rpalcolea
force-pushed
the
main
branch
5 times, most recently
from
14d2949 to
ef876dc
Compare
rpalcolea
force-pushed
the
main
branch
2 times, most recently
from
425767b to
fd9e3e1
Compare
rpalcolea
force-pushed
the
main
branch
3 times, most recently
from
bc27559 to
6fe420a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because dependencies are "transitive" in the global context because they're depended on by a project, we need to ensure that anything a project directly depends on is not excluded from the list of forces.