Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] - Use GitHub secrets instead of Vault #2889

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

[ENH] - Use GitHub secrets instead of Vault #2889

wants to merge 4 commits into from

Conversation

smokestacklightnin
Copy link

Reference Issues or PRs

Resolves #2835

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

@marcelovilla
Copy link
Member

Thanks @smokestacklightnin, this looks good!

We'll wait for @dcmcand to come back so we can add the secrets and test the workflows. I think the provider workflow won't run from a fork and the other three (aws, azure and gcp) will need to be triggered manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Status: New 🚦
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ENH] - Use GitHub secrets instead of Vault
2 participants
@smokestacklightnin @marcelovilla