chore: update 3.3.2 mainnet contract history, clean-up previous contract migrations #1914
Conversation
gilcu3
force-pushed
the
1912-332-in-mainnet-contract-history
branch
from
439c4ea to
2abc2ca
Compare
| pub mod utils; | ||
| pub mod v3_0_2_state; | ||
| pub mod v3_2_0_state; | ||
| pub mod v3_3_2_state; |
There was a problem hiding this comment.
I am not 100% if we were leaving the old states on purpose, but taking into account that our contract size is already near dangerous sizes, I opted for only leaving the necessary code there
There was a problem hiding this comment.
We had a window where 3_0_2 was on mainnet and 3_2_0 was on testnet.
We can and should delete both the previous state modules in this PR now that they are unused.
There was a problem hiding this comment.
ouch, I thought I had done so 🙃
gilcu3
force-pushed
the
1912-332-in-mainnet-contract-history
branch
from
2abc2ca to
1460b02
Compare
DSharifi
left a comment
DSharifi
left a comment
There was a problem hiding this comment.
Looks good to me.
Blocker:
- Please delete the previous state modules
v3_0_2_state.rsandv3_2_0_state.rsnow that they are dead code
| pub mod utils; | ||
| pub mod v3_0_2_state; | ||
| pub mod v3_2_0_state; | ||
| pub mod v3_3_2_state; |
There was a problem hiding this comment.
We had a window where 3_0_2 was on mainnet and 3_2_0 was on testnet.
We can and should delete both the previous state modules in this PR now that they are unused.
gilcu3
force-pushed
the
1912-332-in-mainnet-contract-history
branch
from
1460b02 to
12a20af
Compare
barakeinav1
left a comment
barakeinav1
left a comment
There was a problem hiding this comment.
approving as a secondary reviewer.
Closes #1912 and #1897