Skip to content

Commit c7ed1aa

Browse files
authored
Merge pull request #61 from near-Contact-Reminder/qa/#57-feature-contact-cycle
[QA] 연락처 주기 설정 바텀시트 날짜 형식 수정
2 parents 79651e1 + add9b61 commit c7ed1aa

11 files changed

Lines changed: 337 additions & 435 deletions

File tree

Near/app/src/main/java/com/alarmy/near/presentation/feature/friendcontactcycle/components/ContactCycleContent.kt

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import androidx.compose.ui.unit.dp
2727
import com.alarmy.near.R
2828
import com.alarmy.near.model.ReminderInterval
2929
import com.alarmy.near.presentation.feature.friendcontactcycle.model.FriendContactUIModel
30+
import com.alarmy.near.presentation.ui.component.bottomsheet.CycleSettingBottomSheet
3031
import com.alarmy.near.presentation.ui.component.checkbox.NearBackgroundCheckbox
3132
import com.alarmy.near.presentation.ui.extension.onNoRippleClick
3233
import com.alarmy.near.presentation.ui.theme.NearTheme
@@ -64,10 +65,10 @@ fun ColumnScope.ContactCycleContent(
6465
)
6566
}
6667

67-
Spacer(modifier = Modifier.size(14.dp))
68-
6968
// 한번에 설정이 활성화되었을 때만 표시
7069
if (isBulkSettingEnabled) {
70+
Spacer(modifier = Modifier.size(12.dp))
71+
7172
Row(
7273
modifier =
7374
Modifier
@@ -85,7 +86,9 @@ fun ColumnScope.ContactCycleContent(
8586
verticalAlignment = Alignment.CenterVertically,
8687
) {
8788
Text(
88-
text = selectedCycle?.let { DateExtension.getCycleText(it) } ?: stringResource(R.string.friend_contact_cycle_weekly_format, DateExtension.getTodayDayOfWeekInKorean()),
89+
text =
90+
selectedCycle?.let { DateExtension.getCycleText(it) }
91+
?: stringResource(R.string.friend_contact_cycle_weekly_format, DateExtension.getTodayDayOfWeekInKorean()),
8992
style = NearTheme.typography.B2_14_MEDIUM,
9093
color = NearTheme.colors.BLACK_1A1A1A,
9194
)
@@ -101,7 +104,7 @@ fun ColumnScope.ContactCycleContent(
101104

102105
// 리스트가 있을 때만 밑에 리스트 표시
103106
if (contacts.isNotEmpty()) {
104-
Spacer(modifier = Modifier.size(16.dp))
107+
Spacer(modifier = Modifier.size(24.dp))
105108

106109
LazyColumn(
107110
modifier = Modifier.weight(1f),

Near/app/src/main/java/com/alarmy/near/presentation/feature/friendcontactcycle/components/ContactLoadContent.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ fun FriendListItem(
117117
modifier = Modifier.weight(1f),
118118
) {
119119
Image(
120-
painter = painterResource(R.drawable.img_100_character_default),
120+
painter = painterResource(R.drawable.img_64_user_gray),
121121
contentDescription = null,
122122
modifier = Modifier.size(24.dp),
123123
)

Near/app/src/main/java/com/alarmy/near/presentation/feature/friendcontactcycle/components/CycleSettingBottomSheet.kt

Lines changed: 0 additions & 214 deletions
This file was deleted.

Near/app/src/main/java/com/alarmy/near/presentation/feature/friendcontactcycle/components/NearListModuleBackground.kt

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,13 @@ import androidx.compose.material3.Text
1212
import androidx.compose.runtime.Composable
1313
import androidx.compose.ui.Alignment
1414
import androidx.compose.ui.Modifier
15-
import androidx.compose.ui.draw.shadow
15+
import androidx.compose.ui.graphics.Color
1616
import androidx.compose.ui.res.painterResource
1717
import androidx.compose.ui.res.stringResource
1818
import androidx.compose.ui.tooling.preview.Preview
1919
import androidx.compose.ui.unit.dp
2020
import com.alarmy.near.R
21+
import com.alarmy.near.presentation.ui.extension.dropShadow
2122
import com.alarmy.near.presentation.ui.extension.onNoRippleClick
2223
import com.alarmy.near.presentation.ui.theme.NearTheme
2324

@@ -38,8 +39,12 @@ fun NearListModuleBackground(
3839
modifier =
3940
modifier
4041
.fillMaxWidth()
41-
.shadow(
42-
elevation = 4.dp,
42+
.dropShadow(
43+
blur = 16.dp,
44+
offsetX = 0.dp,
45+
offsetY = 4.dp,
46+
spread = 0.dp,
47+
color = Color.Black.copy(alpha = 0.12f),
4348
shape = RoundedCornerShape(12.dp),
4449
).background(
4550
color = NearTheme.colors.WHITE_FFFFFF,

Near/app/src/main/java/com/alarmy/near/presentation/feature/friendprofileedittor/FriendProfileEditorScreen.kt

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ import com.alarmy.near.model.Friend
4545
import com.alarmy.near.model.Relation
4646
import com.alarmy.near.model.ReminderInterval
4747
import com.alarmy.near.presentation.feature.friendprofileedittor.component.NearDatePicker
48-
import com.alarmy.near.presentation.feature.friendprofileedittor.component.ReminderIntervalBottomSheet
48+
import com.alarmy.near.presentation.ui.component.bottomsheet.CycleSettingBottomSheet
4949
import com.alarmy.near.presentation.feature.friendprofileedittor.dialog.EditorExitDialog
5050
import com.alarmy.near.presentation.feature.friendprofileedittor.uistate.FriendProfileEditorUIEvent
5151
import com.alarmy.near.presentation.feature.friendprofileedittor.uistate.FriendProfileEditorUIState
@@ -140,14 +140,16 @@ fun FriendProfileEditorScreen(
140140
onCloseDialog: () -> Unit = {},
141141
) {
142142
val showBottomSheet = remember { mutableStateOf(false) }
143-
if (showBottomSheet.value) {
144-
ReminderIntervalBottomSheet(onDismissRequest = {
143+
CycleSettingBottomSheet(
144+
isVisible = showBottomSheet.value,
145+
onDismiss = {
145146
showBottomSheet.value = false
146-
}, onSelectReminderInterval = {
147-
onReminderIntervalChanged(it)
148-
showBottomSheet.value = false
149-
})
150-
}
147+
},
148+
onComplete = { selectedInterval ->
149+
onReminderIntervalChanged(selectedInterval)
150+
},
151+
currentSelectedInterval = friendProfileEditorUIState.contactFrequency.reminderInterval,
152+
)
151153
if (dialogState) {
152154
EditorExitDialog(
153155
onDismissRequest = {

0 commit comments

Comments
 (0)