-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.summarizeSoilTemperature() #65
Comments
This function is exported as sharpshootR has If Since there are several other packages currently being developed in this realm I wonder whether there is another place to put further work on these things. I don't really have strong opinions either way, but I feel like we could probably make a more harmonious interface to our various soil climate related tools. SoilTaxonomy or sharpshootR could be good existing places to put things, as SMR/STR are clearly related to taxonomy, and sharpshootR already provides some climate modelling/visualization interfaces. I wonder if a relatively low dependency {SoilClimate} package would be useful for abstracting out these types of function, allowing them to be more easily shared between soilDB, SoilTaxonomy, sharpshootR, rnewhall, rosettaPTF, jNSMR etc. |
This is a good idea. I think that there are enough functions / functionality spread across Also in
Some or all of those are good candidates. I'm on the fence about functions for "getting" data such as |
I would agree that those could make a great new package. I think soilDB should handle functions for getting data. Possibly some functions from sharpshootR ought to be brought into soilDB in this reshuffling. The functions involving web services are a pain in the butt and might be best kept under one roof. Another area where this new soil climate package could focus is on NA-filling and related data quality measures e.g. #27 |
OK, so maybe put CDEC stuff into |
It would be nice to make moves on restructuring some of the namespaces around this topic. Could soilDB adopt the web service related tools from sharpshootR? i.e. CDEC, LL2PLSS, PLSS2LL, ...? What would a soil climate or soil taxonomy (with climate-related tools) package/namespace look like? What do we need in SoilTaxonomy to make that happen (if anything)? |
Agreed. Moving the www service stuff into soilDB seems like a good idea, happy to help. As for the soil climate / taxonomy packages:
I'm happy to discuss, but seems like the SoilTaxonomy package should remain close to its current goals: making ST simpler to navigate, formative elements, parsing, and eventually (?) navigation of the 'Keys. |
TODO
Notes
This function currently estimates MAST, MSST, MWST by taking the mean (sensor value) by sensor / julian day. It would be nice to have an alternate method based on fitting a smooth function via GAM with periodic smoother--if there are enough data to support it. Perhaps smooth function with sensor/julian day mean as a fall back.
For example:
The text was updated successfully, but these errors were encountered: