-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
production build fails when CSS module is imported on multiple pages #126
Comments
natemoo-re
added a commit
that referenced
this issue
Mar 1, 2021
Merged
natemoo-re
added a commit
that referenced
this issue
Mar 1, 2021
@mxmul I fixed this and refactored the output structure a bit. Feel free to reopen if you're still running into problems with |
natemoo-re
added a commit
that referenced
this issue
Mar 3, 2021
natemoo-re
added a commit
that referenced
this issue
Mar 19, 2021
natemoo-re
added a commit
that referenced
this issue
Mar 19, 2021
* wip: [email protected] changes * fix: remove custom document logic from dev * wip: remap [email protected] default output directories * fix(#81): remove PostCSS from core dependencies * fix(#81): remove prettier from core dependencies * fix(83): exclude image/font MIME types from transform * fix(dev): implements a few more [email protected] changes * Ensure shared hydration chunks are included in build (#105) Also include updated package-lock.json based on instructions in https://github.com/natemoo-re/microsite/blob/1853843192cb9e0baa8ff93f872cb595a64fbe7f/.github/CONTRIBUTING.md * Ensure head is rendered for SSG It seems the implementation was intended to achieve this sort of isolation the same way `docContext` is used. But the `useRef` version was basically just sending any children in `Head` into the memory hole on build. * Add another page just to validate that each page gets a new head context as expected * chore: changeset * chore: release 1.1.0-next.4 * Fix an issue with binary public file corruption (#110) * Ensure head is rendered for SSG It seems the implementation was intended to achieve this sort of isolation the same way `docContext` is used. But the `useRef` version was basically just sending any children in `Head` into the memory hole on build. * Add another page just to validate that each page gets a new head context as expected * Fix an issue with binary public file corruption The previous behavior was reading binary files as strings, which was corrupting them on output * fix: missed rebase issue * fix: properly resolve example script in CI * fix: remove assumption that code lives in "node_modules" * fix(examples): prefer readFile to fetch * fix: pin preact to 10.5.10 * fix: pin snowpack to 3.0.x * chore: changeset * chore: v1.1.0-next.5 * chore: fixup package-locks * chore: fixup package-lock files * chore: ignore logfiles * Fix requestIdleCallback logic (#112) * fix(#111): hydration failure in safari * chore: update package lock * fix(#111): use requestIdleCallback shim * chore: changeset * fix: update createPersistentFragment for [email protected]+ * chore: changeset * chore: v1.1.0-next.6 * chore: bump package-lock * chore: update example locks * fix(#119): remove `defer` from inline script * Omit base tag by default (#117) * Omit base tag by default * Ensure resources are prefixed with `/` when base tag is omitted * Lol whoops I meant to remove this * fix(#115): do not include vendor chunk in hydrateBindings * chore: publish [email protected] * chore: add changeset * chore: v1.1.0-next.7 * chore(deps): [email protected] * fix(#125): prefer pinned Skypack URLs * chore: remove debug * chore: changeset * chore: 1.1.0-next.8 * WIP: dev ssr (#113) * fix(dev): implements a few more [email protected] changes * Ensure shared hydration chunks are included in build (#105) Also include updated package-lock.json based on instructions in https://github.com/natemoo-re/microsite/blob/1853843192cb9e0baa8ff93f872cb595a64fbe7f/.github/CONTRIBUTING.md * chore: fixup package-locks * chore: fixup package-lock files * chore: update example locks * WIP: dev ssr * WIP: dev ssr getStaticProps/Paths * feat: add proper error page handling in dev mode * chore(examples): update deps * feat: finalize dev SSR support * chore(examples): add CSS-in-JS examples * chore(examples): update goober example * fix: cleanup deps Co-authored-by: eyelidlessness <[email protected]> * fix(#126): emit shared css modules (#127) * chore: v1.1.0-next.9 * chore: remove package-locks? * fix: shared CSS module logic * chore: 1.1.0-next.10 * feat(hydration): add "fallback" prop to "withHydrate" * fix: global chunk loading * chore(examples): add custom ssr fallback example * chore: v1.1.0-next.11 * Add benchmark action (#129) * feat: add gzip/brotli to benchmark * chore(action): add benchmark test action * chore(action): test benchmark * chore(action): test benchmark * chore(action): update benchmark filter * chore(action): update benchmark scripts * chore: revert lockfile to v1 * chore(action): update benchmark script * chore(action): update benchmark script * chore(action): update benchmark action * chore(action): update benchmark script * chore(action): update benchmark script * chore(action): update benchmark script * chore(action): update benchmark script * chore(action): update benchmark script * chore(action): add context to benchmark message * chore(action): update benchmark to 15 runs * chore(action): require manual trigger for benchmark action * chore(action): fixup benchmark script * chore(action): add commit to benchmark action * chore(action): fix workflow_dispatch * docs: update benchmark * chore: update benchmark table formatting * chore(bench): restructure benchmarks * chore(bench): add counter example * chore(bench): add lighthouse scores to benchmark * chore(bench): run benchmarks * chore(bench): update size label * Fix preact import regex matching other things (#135) * docs: fix wrong variable, update css in js context (#131) * doc: fix wrong variable name * doc: fix file naming, since it doesn't render jsx * doc: adding with-fela and with-goober example * update without .md extension * Update styling.md * Fix preact import regex matching other things Currently preact import regex matches other things (e.g @mdx-js/preact). * Escape forward slashes Co-authored-by: Sigit Prabowo <[email protected]> Co-authored-by: Nate Moore <[email protected]> * Fix incorrect field used for aliases from snowpack user config (#136) * docs: fix wrong variable, update css in js context (#131) * doc: fix wrong variable name * doc: fix file naming, since it doesn't render jsx * doc: adding with-fela and with-goober example * update without .md extension * Update styling.md * Fix aliases from userConfig not being loaded Co-authored-by: Sigit Prabowo <[email protected]> Co-authored-by: Nate Moore <[email protected]> * Ensure nested imports are hydrated, allow optional display name override for named exports (#140) * final changes for v1.1.0 Co-authored-by: eyelidlessness <[email protected]> Co-authored-by: eyelidlessness <[email protected]> Co-authored-by: Reeto Chatterjee <[email protected]> Co-authored-by: Sigit Prabowo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Minimal repro
./src/pages/page-a.module.css:
./src/pages/page-a.tsx:
./src/pages/page-b.tsx (same as
page-a.tsx
):Expectation
This should result in a shared CSS asset that's loaded on both
page-a.html
andpage-b.html
.Actual
note: this works fine in dev mode
The text was updated successfully, but these errors were encountered: