Edit command: Incorrect error message shown to users

[nat-ong555]

Description: When trying to edit a person at an invalid index, the error message shown does not reflect the invalid index problem

Steps to reproduce:

1. Open TalentFolio.jar with the existing sample data loaded in the list
2. edit 13 (or any invalid index not in the list)

Expected: The error message "Provided index is invalid" is shown

Actual: "At least one non-empty field to edit must be provided"

Instead of prompting the user to add in the field they want to edit, perhaps you could already tell them that the provided index is invalid, as they may have many candidates to look through and did not realise they keyed in the wrong index

[nus-pe-bot]

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Hi, thank you for your feedback.

The command edit 13 has multiple issues with the format: in addition to the index being out of range, no parameters to edit are specified. The error message shown here is correct. If we instead showed the other error regarding the index being invalid, correcting this index still would not be sufficient (since the user did not specify parameters to edit).

Showing multiple error messages instead of just one may be useful, but doing so is less important than the work done in the current version of the product, hence we are classifying this as response.NotInScope.

Items for the Tester to Verify

❓ Issue response

Team chose [response.NotInScope]

• I disagree

Reason for disagreement: [replace this with your explanation]

---