-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: turn query radii for the different archives into astropy quantities #350
Comments
Generally, I agree, but in this case (as I recall) the scale_up.md notebook needs these to be floats (or ints) because the functions are called from the command line. So if they get changed to astropy quantities we will need to implement a workaround in scale_up.md. OTOH, we'll probably want to revisit the parallel cell in this notebook because this PR removes Pan-STARRS from the [*] scale_up.md describes the underlying bash code but doesn't actually execute it at scale -- the user is instructed to do that directly from the command line. |
Do they need to be floats in the API signature can that conversion be an internal thing? |
That would be the workaround I mentioned. We'd have to implement it. |
Hmm, we could have it both ways, that's actually what we do all around in pyvo, too (though we do that as the standards are very clear what the unit is when a float is provided). We can just always assume that one needs to be really careful when running things from the command line, vs the recommended user API of working with quantities and not paying any attention of the desired units of the various services. |
From Brigitta in a comment on PR #344
it would ultimately be nice if these radiuses could be any astropy quantity rather than a float, of which the user should keep track if arcsec, or arcmin, or degrees, depending on which datasets they are querying.
The text was updated successfully, but these errors were encountered: