Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine steps (functions) into main (larger) functions #257

Open
jkrick opened this issue Mar 28, 2024 · 0 comments
Open

Combine steps (functions) into main (larger) functions #257

jkrick opened this issue Mar 28, 2024 · 0 comments

Comments

@jkrick
Copy link
Contributor

jkrick commented Mar 28, 2024

There are many data cleaning type functions in this notebook which need to be called twice. Once at the top and once again at the bottom of the notebook. It might be easier to group these into main functions.

Suggestion from @troyraen as to what those main functions might be: 1) Clean the data - drop bands, sigma clip, etc.; 2) Transform the data - uniform spacing, normalize, etc.; 3) Transform the data structure - pivot, drop columns, set index.

If clumping together functions, suggestion is to make it more clear what those functions are doing by using keyword arguments with booleans True/False for each step within the main function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant