Parse pypi and github URLs correctly #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Example plugins with missing information before:
|
willingc
approved these changes
Jul 20, 2025
Collaborator
willingc
left a comment
willingc
left a comment
There was a problem hiding this comment.
Makes sense to me. Thanks @DragaDoncila. A few comment nitpicks. Feel free to 🚢
| Returns | ||
| ------- | ||
| None | ||
| The function modifies the `plugin_data` dictionary in place. |
Collaborator
There was a problem hiding this comment.
I'm not a huge fan of modifying in-place but this follows the pattern in the repo so no worries.
Co-authored-by: Carol Willing <[email protected]>
willingc
added a commit
that referenced
this pull request
Jul 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this PR our retrieval of github URLs was missing many plugins because it did not inspect the
project_urlfield. This PR updates the logic for fetching this information to include checking both thehome_pageandproject_url. It also retrieves the PyPI url from the PyPI api information as this is likely to be more stable.In future we should also add a link to the conda URL information (if present), and potentially parse documentation/bugtracker/etc. links for display. However that would require more icons/CSS/layout changes and I'd rather get #75 and #81 done first. I thought this was valuable enough to get it in asap.