Don't throw error if no instance in history

Sebastian Schöps · Sebastian Schöps · commit e6ccfbfb6f0c · 2020-12-02T17:26:00.000+01:00
diff --git a/src/Models/ProcessInstance.php b/src/Models/ProcessInstance.php
@@ -72,6 +72,12 @@ public function deleteProcessInstances($processInstanceIds, $deleteReason = 'non
 
     public function ended()
     {
+        $processInstance = $this->get('history/process-instance/?processInstanceId=' . $this->id);
+
+        if(count($processInstance) == 0) {
+            return true;
+        }
+
         return $this->get('history/process-instance/?processInstanceId=' . $this->id)[0]->state == 'COMPLETED';
     }
     

Original file line number	Diff line number	Diff line change
`@@ -72,6 +72,12 @@ public function deleteProcessInstances($processInstanceIds, $deleteReason = 'non`
`72`	`72`
`73`	`73`	`public function ended()`
`74`	`74`	`{`
	`75`	`+ $processInstance = $this->get('history/process-instance/?processInstanceId=' . $this->id);`
	`76`	`+`
	`77`	`+ if(count($processInstance) == 0) {`
	`78`	`+ return true;`
	`79`	`+ }`
	`80`	`+`
`75`	`81`	`return $this->get('history/process-instance/?processInstanceId=' . $this->id)[0]->state == 'COMPLETED';`
`76`	`82`	`}`
`77`	`83`