Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error building with MinGW-w64 in mkdir() in src/supplemental/nanolib/file.c #875

Open
brechtsanders opened this issue Feb 22, 2024 · 1 comment
Assignees

Comments

@brechtsanders
Copy link

Describe the bug
When building natively on Windows with MinGW-w64 there was an error in src/supplemental/nanolib/file.c in the following line=

ret = mkdir(fpath, 0777);

The problem is that mkdir() only takes one argument on Windows.

However there seems to be a solution for this in the same file by defining the nano_mkdir() macro.

Replacing the above line with the following does allow it to build:

ret = nano_mkdir(fpath, 0777);
@JaylinYu
Copy link
Member

Oh, yep, The code in this file is obsolated mostly, you can remove file_create_dir() API. or wait for our next release

@JaylinYu JaylinYu self-assigned this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants