From abf5fc0507aeeb0d897d18c961477f7d37463b99 Mon Sep 17 00:00:00 2001 From: Phil martin Date: Mon, 16 May 2022 22:17:25 +0100 Subject: [PATCH] dsnet-nsupdate now checks if resulting PTR records are in the reverse zones before attempting to update them --- contrib/dsnet-nsupdate/dsnet-nsupdate | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/contrib/dsnet-nsupdate/dsnet-nsupdate b/contrib/dsnet-nsupdate/dsnet-nsupdate index 92b24ad..6de6092 100755 --- a/contrib/dsnet-nsupdate/dsnet-nsupdate +++ b/contrib/dsnet-nsupdate/dsnet-nsupdate @@ -439,12 +439,20 @@ def main(): # Check reverse IPv4 record if new_peers[peer]['reverse_ptr'] != current_peers[peer]['reverse_ptr']: # Update if the PTR records don't match - update_ptr_peers.append(peer) + # Check if it's in our IPv4 reverse zone + if new_peers[peer]['reverse'].endswith(dsnet_reverse_zone): + update_ptr_peers.append(peer) + else: + logger.warn(peer + " internal IPv4 not in our reverse zone!") # Check reverse IPv6 record if new_peers[peer]['reverse6_ptr'] != current_peers[peer]['reverse6_ptr']: # Update if the PTR records don't match - update_ptr6_peers.append(peer) + # Check if it's in our IPv6 reverse zone + if new_peers[peer]['reverse6'].endswith(dsnet_reverse6_zone): + update_ptr6_peers.append(peer) + else: + logger.warn(peer + " internal IPv6 not in our reverse zone!") # List peers we're adding if add_peers: