Skip to content

Commit 43d2f62

Browse files
authored
chore(ci): run cargo build for android platforms (#1843)
## Description Due to a bug in redb we are currently not running tets on android. This is a bit problematic as we break android builds this way. This makes sure we can at least build, so the linker will also run. ## Notes & open questions The next step would be to run the tests for android which do not depend on redb. Running `cargo check` in a separate step does not provide any benefit, it is an extra compiler step which does take time and does not result in catching errors which otherwise aren't caught. Maybe we should also remove this step from the non-cross checks, but that belongs better in a different PR probably. ## Change checklist - [x] Self-review. - ~~Documentation updates if relevant.~~ - ~~Tests if relevant.~~
1 parent ea6d40b commit 43d2f62

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

.github/workflows/ci.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -280,8 +280,12 @@ jobs:
280280
# See https://github.com/cross-rs/cross/issues/1222
281281
run: cargo install cross --git https://github.com/cross-rs/cross
282282

283-
- name: check
284-
run: cross check --all --target ${{ matrix.target }}
283+
- name: build
284+
# cross tests are currently broken vor armv7 and aarch64
285+
# see https://github.com/cross-rs/cross/issues/1311. So on
286+
# those platforms we only build but do not run tests.
287+
if: matrix.target != 'i686-unknown-linux-gnu'
288+
run: cross build --all --target ${{ matrix.target }}
285289
env:
286290
RUST_LOG: ${{ runner.debug && 'DEBUG' || 'INFO'}}
287291

0 commit comments

Comments
 (0)