From d9c3de28ab32530f5d0e4ba3c91e8fd94bb5d003 Mon Sep 17 00:00:00 2001
From: tolich-aka-shadow <111268416+tolich-aka-shadow@users.noreply.github.com>
Date: Mon, 15 Aug 2022 10:19:07 +0300
Subject: [PATCH] Update ied_connection.c

ClientDataSet_destroy didn't check if self is null, checked if self->dataSetValues is null though MmsValue_delete checks it itself, and GLOBAL_FREEMEMed(self->dataSetValues) though MmsValue_delete GLOBAL_FREEMEMs its parameter unless it's null.
---
 src/iec61850/client/ied_connection.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/iec61850/client/ied_connection.c b/src/iec61850/client/ied_connection.c
index 7bb8a1f2a..a2ae20f3d 100644
--- a/src/iec61850/client/ied_connection.c
+++ b/src/iec61850/client/ied_connection.c
@@ -258,10 +258,10 @@ ClientDataSet_create(const char* dataSetReference)
 void
 ClientDataSet_destroy(ClientDataSet self)
 {
-    if (self->dataSetValues != NULL)
-        MmsValue_delete(self->dataSetValues);
+	if (self == NULL)
+		return;
 
-    GLOBAL_FREEMEM(self->dataSetReference);
+	MmsValue_delete(self->dataSetValues);
 
     GLOBAL_FREEMEM(self);
 }