Skip to content

Commit 2517a82

Browse files
authored
Merge pull request joinpursuit#56 from joinpursuit/mb-avoid-form-event
Remove <form /> elements from README and tests
2 parents 58190a3 + 603d2c9 commit 2517a82

5 files changed

+12
-9
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ Make a website (`numberStatistics.html`) with a number input, a button, and 3 pa
2828

2929
# Question Three: Random User List
3030

31-
Make a website (`userList.html`) that displays a list containing all of the nationality, first name and last name of all of the users below:
31+
Make a website (`userList.html`) that displays a list with id='user-list' containing all of the nationality, first name and last name of all of the users below. Example: `ruth nicolas (CH)`
3232

3333
[Source](https://randomuser.me/api/?inc=gender,name,nat&&results=10)
3434

@@ -137,7 +137,7 @@ Make a website (`userList.html`) that displays a list containing all of the nati
137137

138138
# Question Four: Star Wars Names and Populations
139139

140-
Make a website (`starWars.html`) that displays a list of all of the names and populations of the following Star Wars planets
140+
Make a website (`starWars.html`) that displays a list with id='planets-list' of all of the names and populations of the following Star Wars planets. Example: `Alderaan (pop. 2000000000)`
141141

142142
```js
143143
{

cypress/integration/number_statistics_spec.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ describe("2. Number Statistics", () => {
88
cy.get("#number-statistics-number-input")
99
.clear()
1010
.type(`${value}`)
11-
.get("#number-statistics-form button")
11+
.get("#number-statistics-button")
1212
.click();
1313
}
1414
};

cypress/integration/text_duplicator_spec.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ describe("1. Text Duplicator", () => {
99
.get("#text-duplicator-number-input")
1010
.clear()
1111
.type(`${i}`)
12-
.get("#text-duplicator-form button")
12+
.get("#text-duplicator-button")
1313
.click()
1414
.get("#text-duplicator-list li")
1515
.should("have.length", i)
1616
.each((item) => expect(item).to.contain("Hello world!"))
1717
.get("#text-duplicator-number-input")
1818
.clear()
1919
.type('3')
20-
.get("#text-duplicator-form button")
20+
.get("#text-duplicator-button")
2121
.click()
2222
.get("#text-duplicator-list li")
2323
.should("have.length", i + 3)

numberStatistics.html

+6-2
Original file line numberDiff line numberDiff line change
@@ -7,18 +7,22 @@
77
<h1>Number Statistics</h1>
88

99
<ul>
10-
<li>Make a form with id='number-statistics-form'</li>
1110
<li>
1211
The user should be able to enter a number into a number input with
1312
id='number-statistics-number-input'
1413
</li>
15-
<li>They should then be able to click a "submit" button</li>
14+
<li>They should then be able to click a "submit" button with id='number-statistics-button'</li>
1615
<li>
1716
Clicking the submit button will add that number to a list with
1817
id='number-statistics-numbers'. There should be three paragraphs on the
1918
page: id='number-statistics-average', id='number-statistics-maximum',
2019
and id='number-statistics-minimum'.
2120
</li>
21+
<li>
22+
The first paragraph should show the average of all the numbers,
23+
the second paragraph should show the maximum value,
24+
and the third paragraph should show the minimum value.
25+
</li>
2226
</ul>
2327
</body>
2428
</html>

textDuplicator.html

+1-2
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
<h1>Text Duplicator</h1>
88

99
<ul>
10-
<li>Make a form with id='text-duplicator-form'</li>
1110
<li>
1211
The user should be able to enter a string into a text input with
1312
id='text-duplicator-string-input'
@@ -16,7 +15,7 @@ <h1>Text Duplicator</h1>
1615
The user should be able to enter a number into a number input with
1716
id='text-duplicator-number-input'
1817
</li>
19-
<li>They should then be able to click a "submit" button</li>
18+
<li>They should then be able to click a "submit" button with id='text-duplicator-button'</li>
2019
<li>
2120
Clicking the submit button will add that many copies of the string as
2221
list items to an unordered list with id='text-duplicator-list'

0 commit comments

Comments
 (0)