[API] Report model version in response?

[davidmeijer]

Hi,

Thank you for creating such a useful classifier. I noticed that an API call to NPClassifier does not return a version number of the model being used for classification. Would it be possible to add this for version control on the user end? I assume the API doesn't use V1 anymore.

[abdullah-shouaib]

I second this question - I noticed the only available model for offline use is "V1" which seems to have discrepancies in results when compared to the one used in GNPS. Could the latest version of the model be provided in some way to allow for offline use?

[mwang87]

Thanks!

Do you have a definition of V1? I don't think we've updated the underlying model in years.

[davidmeijer]

V1 is referenced here in the code for downloading the model:
https://github.com/mwang87/NP-Classifier/blob/d454d284accddc72c5a0a1a011fecb82b640718c/Classifier/models_folder/models/get_models.sh#L10

V1 is the only model available on Zenodo:
https://zenodo.org/record/5068687

But when I go to this part of the code base there is a reference to a V25 model:
https://github.com/mwang87/NP-Classifier/blob/d454d284accddc72c5a0a1a011fecb82b640718c/Classifier/NPC_ensemble.py#L64