Skip to content

Commit e50ad47

Browse files
authored
Merge pull request #71 from mvt-project/fix/samsung
Fix package listing for old Samsung devices
2 parents e6bbc56 + 207eaa5 commit e50ad47

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

adb/packages.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,12 @@ func (a *ADB) GetPackages(fast bool) ([]Package, error) {
9292
// Some phones do not support -i option
9393
out, err = a.Shell("pm", "list", "packages", "-U", "-u")
9494
if err != nil {
95-
return []Package{}, fmt.Errorf("failed to launch `pm list packages` command: %v",
96-
err)
95+
// old Samsung throw errors when trying to access installed packages of other users
96+
out, err = a.Shell("pm", "list", "packages", "-U", "-u", "-i", "--user 0")
97+
if err != nil {
98+
return []Package{}, fmt.Errorf("failed to launch `pm list packages` command: %v",
99+
err)
100+
}
97101
}
98102
withInstaller = false
99103
}

0 commit comments

Comments
 (0)