Skip to content

Commit 56336e7

Browse files
NiklasRosensteindominichamon
authored andcommitted
fix argv accessed out of bounds in ParseCommandLineFlags() (google#321)
1 parent efd4e99 commit 56336e7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/benchmark.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -634,7 +634,7 @@ void ParseCommandLineFlags(int* argc, char** argv) {
634634
// TODO: Remove this.
635635
ParseStringFlag(argv[i], "color_print", &FLAGS_benchmark_color) ||
636636
ParseInt32Flag(argv[i], "v", &FLAGS_v)) {
637-
for (int j = i; j != *argc; ++j) argv[j] = argv[j + 1];
637+
for (int j = i; j != *argc - 1; ++j) argv[j] = argv[j + 1];
638638

639639
--(*argc);
640640
--i;

0 commit comments

Comments
 (0)