-
-
Notifications
You must be signed in to change notification settings - Fork 172
joinquit settings support + code refactor #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
joinquit settings support + code refactor #364
Conversation
- Added OOP - Use RGB instead of hex codes for ease of use - No more anonymous functions - Listen for settings changes
|
Regardless of the perceived efficiency, it is simply much easier for most people to read and write object-oriented code. Which is frankly more important than micro-efficiencies and premature optimizations, especially for a project of this magnitude. Writing it this way means it is more accessible to more people, and much easier for people like me who context-switch a lot. I doubt the overhead of OOP degrades performance by such a margin that could be reasonably referred to as "horrible". If you have serious concerns about my code using OOP, please raise them here. Otherwise I fear this is off-topic, but feel free to open an issue and we could discuss OOP usage in this repo potentially. |
Most of people uses POP, i can tell you that by observing scripting help channels from many years. Also, there is way more scripts written in just POP. |
|
@itslewiswatson There is no clear coding guidelines yet, but we won't accept this PR if it uses OOP.. performance hit can be ~ 20% additional load |
|
@Dutchman101 the PR uses good old-fashioned procedural now |

This PR introduces some quality of life improvements to the
joinquitresource, as well as some basic enhancements:*showColorCodessetting which accepts a boolean value*defaultColorsetting which accepts an RGB input, and controls what color to output the message text ingetDefaultColor(which has a fallback now) andgetHexFriendlyNickwhich makes theoutputChatBoxcalls read nicer