Remove or load admin_definitions.lua

[Dark-Dragon]

Which resource(s) have this problem?
admin

Describe the bug
admin_definitions.lua is not in the meta.xml and is therefore never loaded. Now currently the admin resource seems to only have minor issues without it, but having the file around but not loading it causes confusion. For instance #440 didn't properly fix #373, because it assumed the file was loaded.

It should therefore be decided whether the file can be safely removed (I think it's only essential in the admin2 resource) or implemented properly. At the very least the ADMIN_CHAT_MAXLENGTH global variable needs to be set elsewhere if the file is deemed redundant.

To Reproduce

1. start admin
2. see debug warning relating to ADMIN_CHAT_MAXLENGTH being nil
3. find out it makes sense because the file which defines it is never loaded

Version
Client/Server 1.6
admin 1.5.9 (latest at the time of post despite version discrepancy)

[ricksterhd123]

Looking back on this, in hindsight you could remove the ADMIN_CHAT_MAXLENGTH server-side completely and keep it client-side only since it's really only relevant in the GUI, e.g.

mtasa-resources/[admin]/admin/server/admin_server.lua

Lines 1611 to 1622 in c4bc73a

	addEventHandler ( "aAdminChat", root, function ( chat )
	if #chat > ADMIN_CHAT_MAXLENGTH then
	return
	end
	if checkClient( true, source, 'aAdminChat' ) then return end
	for id, player in ipairs(getElementsByType("player")) do
	if ( aPlayers[player]["chat"] ) then
	triggerClientEvent ( player, "aClientAdminChat", source, chat )
	end
	end
	outputServerLog ("(ADMIN CHAT) "..tostring(getPlayerName(source))..": "..chat)
	end )

This event is triggered in two places, command handler:

mtasa-resources/[admin]/admin/server/admin_server.lua

Lines 1624 to 1630 in c4bc73a

	addCommandHandler(get("adminChatCommandName"),
	function(thePlayer, cmd, ...)
	if hasObjectPermissionTo (thePlayer, "general.tab_adminchat", false) and #arg > 0 then
	triggerEvent("aAdminChat", thePlayer, table.concat(arg, " "))
	end
	end
	)

client-side:

mtasa-resources/[admin]/admin/client/gui/admin_main.lua

Lines 1145 to 1155 in c4bc73a

	elseif ( getElementParent ( source ) == aTab5.Tab ) then
	if ( source == aTab5.AdminSay ) then
	local message = guiGetText ( aTab5.AdminText )
	if ( ( message ) and ( message ~= "" ) ) then
	if ( gettok ( message, 1, 32 ) == "/clear" ) then guiSetText ( aTab5.AdminChat, "" )
	else triggerServerEvent ( "aAdminChat", localPlayer, message ) end
	guiSetText ( aTab5.AdminText, "" )
	end
	--elseif ( source == aTab5.AdminText ) then
	end

I believe the chat already has an upper limit of how many characters you can input so all we need to do is set this client-side to ensure the chat editbox doesn't exceed max limit here:

mtasa-resources/[admin]/admin/client/gui/admin_main.lua

Line 331 in c4bc73a

guiEditSetMaxLength(aTab5.AdminText, ADMIN_CHAT_MAXLENGTH)

[Dark-Dragon]

It should be all good for chat, but console input is a maximum of 255, which with a prior 'aAdminChat ' would still allow for 244 characters. So it unfortunately still surpasses the limit of 225 brought up in #440.

[jlillis]

I have a fix for this in mind and will try to get it out this coming weekend.