Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HUD size when playing on widescreen #3444

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

henrymarques
Copy link

@henrymarques henrymarques commented Jun 8, 2024

Fix #848, maybe fix #2753
There's nothing new, most part of the code is from ThirteenAG's widescreen fix (thanks).

This is a draft pull request because it needs more testing. If you can test it, please, send me feedback.
I need feedback about the code too.

Copy link
Contributor

@FileEX FileEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice that you are willing to do it. There are still a lot of things to improve, better readability, etc. Personally, I don't like these huge address tables.

Keep it up!

@henrymarques
Copy link
Author

I've read all the reviews, I will reply and work on the changes when I have a break

@Fernando-A-Rocha
Copy link
Contributor

Fernando-A-Rocha commented Jun 18, 2024

thank you for your work, i hope this is finished :D

hud looks like this without your PR, stretched and too big 😔
image

@Fernando-A-Rocha
Copy link
Contributor

vs on samp with widescreen hud fix

image

@DomenicF
Copy link

DomenicF commented Jul 9, 2024

Thanks for working on this!

Just curious if this fix also covers FoV issues (reported in #2753) or if the fix would be a totally separate thing?

@henrymarques
Copy link
Author

Just curious if this fix also covers FoV issues [...] or if the fix would be a totally separate thing?

Not yet, it's not totally separate thing but I think I will open another pull request to this

@henrymarques henrymarques marked this pull request as ready for review July 13, 2024 23:06
@henrymarques
Copy link
Author

Everything seems to work correctly, but I would like if another dev could test this

@henrymarques henrymarques marked this pull request as draft July 17, 2024 19:02
@henrymarques
Copy link
Author

henrymarques commented Jul 18, 2024

At this point, HUD size can be changed back switching aspect ratio to 4:3 on video settings, I don't know if this setting change could have side effects elsewhere than HUD. If this happen, please tell me, so I will think how to solve with "HUD match aspect ratio" setting checkbox. I will work on fov fix now

EDIT:

[...] I don't know if this setting change could have side effects elsewhere than HUD.

It has, but I found a way to solve using "HUD match aspect ratio" checkbox. I don't think it's the better way but it works, also, unfortunetly the game needs to restart to apply changes. I can commit it as is to this PR if someone thinks it is needed

@henrymarques henrymarques marked this pull request as ready for review July 22, 2024 19:10
@henrymarques henrymarques requested a review from FileEX July 23, 2024 22:21
@Fernando-A-Rocha
Copy link
Contributor

Related to #3582 ?

@henrymarques
Copy link
Author

henrymarques commented Jul 25, 2024

Related to #3582 ?

You can see the changes here, I don't think it's the better way to do this, so I didn't include in this PR

@Nico8340
Copy link
Contributor

Nico8340 commented Jan 4, 2025

Any updates on this? This is a long awaited feature, actually the issue is in the 1.6.1 milestone

@lynconsix
Copy link

It would be very interesting if this pull returned

@ghost
Copy link

ghost commented Jan 4, 2025

I personally like the current "big" hud for 1080p (bad eyes) but I understand that it gets too big on 4k screens. An option where you could scale the hud is impossible?

@henrymarques
Copy link
Author

Hello! I was very sick last 4 months but I can continue this pr now, I do not remember what I was doing but I got issues with memory addresses as FileEX mentioned, maybe we could separate this into 2 pr since hud changes is ready (at least was before FileEX hud customizations but it seems easy to make it work again)

@henrymarques
Copy link
Author

I personally like the current "big" hud for 1080p (bad eyes) but I understand that it gets too big on 4k screens. An option where you could scale the hud is impossible?

HUD match aspect ratio option will be kept, so you can use the big HUD simply unchecking that option, isn't the best solution but implementing HUD scale without making things weird needs more thinking

@Fernando-A-Rocha
Copy link
Contributor

Fernando-A-Rocha commented Jan 11, 2025

Nice!
Will you add a client setting to keep the old hud? It should be disabled by default because your fixed version is nicer, imo

@henrymarques
Copy link
Author

Nice! Will you add a client setting to keep the old hud? It should be disabled by default because your fixed version is nicer, imo

Yes, just uncheck "HUD match aspect ratio" checkbox on video options, it's checked by default (which means that will be using fixed hud)

@henrymarques henrymarques requested a review from FileEX January 15, 2025 13:55
Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ultrawidescreen (32:9) HUD and FOV issue Widescreen Hud Placement
6 participants