-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HUD size when playing on widescreen #3444
base: master
Are you sure you want to change the base?
Fix HUD size when playing on widescreen #3444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's nice that you are willing to do it. There are still a lot of things to improve, better readability, etc. Personally, I don't like these huge address tables.
Keep it up!
I've read all the reviews, I will reply and work on the changes when I have a break |
Thanks for working on this! Just curious if this fix also covers FoV issues (reported in #2753) or if the fix would be a totally separate thing? |
Not yet, it's not totally separate thing but I think I will open another pull request to this |
Everything seems to work correctly, but I would like if another dev could test this |
…into bugfix/widescreen Update branch with master
At this point, HUD size can be changed back switching aspect ratio to 4:3 on video settings, I don't know if this setting change could have side effects elsewhere than HUD. If this happen, please tell me, so I will think how to solve with "HUD match aspect ratio" setting checkbox. I will work on fov fix now EDIT:
It has, but I found a way to solve using "HUD match aspect ratio" checkbox. I don't think it's the better way but it works, also, unfortunetly the game needs to restart to apply changes. I can commit it as is to this PR if someone thinks it is needed |
Related to #3582 ? |
Any updates on this? This is a long awaited feature, actually the issue is in the 1.6.1 milestone |
It would be very interesting if this pull returned |
…at/hud-size-change
I personally like the current "big" hud for 1080p (bad eyes) but I understand that it gets too big on 4k screens. An option where you could scale the hud is impossible? |
Hello! I was very sick last 4 months but I can continue this pr now, I do not remember what I was doing but I got issues with memory addresses as FileEX mentioned, maybe we could separate this into 2 pr since hud changes is ready (at least was before FileEX hud customizations but it seems easy to make it work again) |
HUD match aspect ratio option will be kept, so you can use the big HUD simply unchecking that option, isn't the best solution but implementing HUD scale without making things weird needs more thinking |
Nice! |
Yes, just uncheck "HUD match aspect ratio" checkbox on video options, it's checked by default (which means that will be using fixed hud) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix #848, maybe fix #2753
There's nothing new, most part of the code is from ThirteenAG's widescreen fix (thanks).
This is a draft pull request because it needs more testing. If you can test it, please, send me feedback.
I need feedback about the code too.