Flatten the condition to get rid of empty branch (discord#247)

janisozaur · msciotti · commit ac2d064cb0e7 · 2018-11-06T14:48:59.000-08:00
diff --git a/src/rpc_connection.cpp b/src/rpc_connection.cpp
@@ -26,12 +26,8 @@ void RpcConnection::Open()
         return;
     }
 
-    if (state == State::Disconnected) {
-        if (connection->Open()) {
-        }
-        else {
-            return;
-        }
+    if (state == State::Disconnected && !connection->Open()) {
+        return;
     }
 
     if (state == State::SentHandshake) {

Original file line number	Diff line number	Diff line change
`@@ -26,12 +26,8 @@ void RpcConnection::Open()`
`26`	`26`	`return;`
`27`	`27`	`}`
`28`	`28`
`29`		`- if (state == State::Disconnected) {`
`30`		`- if (connection->Open()) {`
`31`		`- }`
`32`		`- else {`
`33`		`- return;`
`34`		`- }`
	`29`	`+ if (state == State::Disconnected && !connection->Open()) {`
	`30`	`+ return;`
`35`	`31`	`}`
`36`	`32`
`37`	`33`	`if (state == State::SentHandshake) {`