Added sharness test of cli #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makefile
Outdated
| @@ -10,6 +10,10 @@ deps: gx covertools | |||
| gx --verbose install --global | |||
| gx-go rewrite | |||
|
|
|||
| sharness: deps | |||
| git clone https://github.com/multiformats/multihash.git $(TRAVIS_BUILD_DIR)/sharness | |||
There was a problem hiding this comment.
Maybe not use the TRAVIS_BUILD_DIR variable? We might want to run this locally
|
Hey @tabrath sorry about the delay (lots of projects, can only get to so many in a day). Do you mind rebasing this on master? The changes here also contain the changes for adding keccak (which has already been merged). |
|
I think it's good now.. |
tabrath
force-pushed
the
feat/sharness
branch
2 times, most recently
from
cb29148 to
569f937
Compare
tabrath
force-pushed
the
feat/sharness
branch
3 times, most recently
from
e1c6d27 to
10f2652
Compare
Pulling from the multihash sharness repository to run tests of the cli tool. Forgot cache dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.