Repository navigation
Conversation
commit: |
✅ Deploy Preview for base-ui ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Bundle size
PerformanceNo regressions in 36 benchmarks · ran 4m 11s · details Check out the code infra dashboard for more information about this PR. |
mdm317
marked this pull request as ready for review
November 7, 2026 17:05
mdm317
requested review from
atomiks,
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
November 7, 2026 17:05
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the pointer moves from one item to another,
pointerleave'srelatedTargetis the element it lands on:relatedTargetis Item 2, so the highlight was kept.relatedTargetis<span>Banana</span>.onPointerLeaveonly checkedlistRef.current.includes(relatedTarget), so in the second case it treated the move as leaving the list and cleared the highlight. The nextmousemoveset it again, causing an extra state update and React commit.Changes
Check whether
relatedTargetis inside any item (withcontains) instead of matching only the item elements, so child elements of items count too.Side effect: consistent highlight while scrolling
Hovering an item and then scrolling the list without moving the pointer:
Performance
Measured in headless Chromium with a production React 19 build and 4x CPU throttling, as medians of 30 interleaved runs. Each item's text fills the item, so the pointer enters the next item's text directly. Each run parks the pointer on Item 0, then moves it with real mouse input one item at a time to Item 20 (20 boundary crossings).
Select
Combobox (100 items)
Tests
Added to
popupListConformanceTests