Stop using the deprecated utf8 API on RE2::Options #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub: #40 As re2 has deprecated [0] and now removed [1] the utf8 option, re-implement the option in the gem in terms of the encoding and set_encoding API. This should be entirely backward-compatible as the encoding API has been present since the initial release in 2010. Thanks to @buzzdeee for reporting this upcoming breaking change. [0]: google/re2@58141dc#diff-6dc69df7618951357bb5fb674c66aa34R640 [1]: google/re2@ac65d45#diff-6dc69df7618951357bb5fb674c66aa34L640-L649
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub: #40
As re2 has deprecated and now removed the utf8 option, re-implement the option in the gem in terms of the encoding and set_encoding API.
This should be entirely backward-compatible as the encoding API has been present since the initial release in 2010.
Thanks to @buzzdeee for reporting this upcoming breaking change.