From e29b5529080d3f24f96444e9bcd3b0f0e7808ea7 Mon Sep 17 00:00:00 2001 From: Kaylee Lubick Date: Mon, 19 Aug 2024 10:15:05 -0400 Subject: [PATCH] Update gni filegroup when building Skia's codec files (#54588) This was added in https://skia-review.googlesource.com/c/skia/+/890319 and Skia plans to delete the old group. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I added new tests to check the change I am making or feature I am adding, or the PR is [test-exempt]. See [testing the engine] for instructions on writing and running engine tests. - [ ] I updated/added relevant documentation (doc comments with `///`). - [x] I signed the [CLA]. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. [Contributor Guide]: https://github.com/flutter/flutter/wiki/Tree-hygiene#overview [Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene [test-exempt]: https://github.com/flutter/flutter/wiki/Tree-hygiene#tests [Flutter Style Guide]: https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style [testing the engine]: https://github.com/flutter/flutter/wiki/Testing-the-engine [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/wiki/Chat --- skia/BUILD.gn | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/skia/BUILD.gn b/skia/BUILD.gn index 2218e00265919..72b724c9c64ae 100644 --- a/skia/BUILD.gn +++ b/skia/BUILD.gn @@ -638,7 +638,7 @@ skia_component("skia") { sources += skia_effects_sources sources += skia_colorfilters_sources sources += skia_effects_imagefilter_sources - sources += skia_codec_core + sources += skia_codec_shared sources += skia_codec_decode_bmp sources += skia_encode_srcs sources += skia_sksl_core_sources @@ -649,8 +649,6 @@ skia_component("skia") { "$_skia_root/src/android/SkAnimatedImage.cpp", "$_skia_root/src/codec/SkAndroidCodec.cpp", "$_skia_root/src/codec/SkAndroidCodecAdapter.cpp", - "$_skia_root/src/codec/SkEncodedInfo.cpp", - "$_skia_root/src/codec/SkParseEncodedOrigin.cpp", "$_skia_root/src/codec/SkSampledCodec.cpp", "$_skia_root/src/ports/SkDiscardableMemory_none.cpp", "$_skia_root/src/ports/SkMemory_malloc.cpp",