ed25519 ssh keys do not work

[jmpolom]

It appears that ed25519 ssh keys do not work?

I tried loading an ed25519 ssh key and I get an error. "Failed to fetch from remote. Underlying Error: Failed to authenticate SSH session: Unable to extract public key from private key."

Pass for iOS 0.7.0

This was previously reported in #205 but I wanted to create a separate issue since it seemed like this was supposed to have been fixed with the switch to GopenPGP.

[mssun]

Hi @jmpolom. Thanks for your report.

The SSH channel is established within Git remote operations. Therefore, the SSH key exchange algorithm is not in the PGP library, but in the objective-git library. The issue you were referring is about the PGP library.

So, this is another troublesome issue for a long time caused by our upstream library (objective-git). I think the support of ED25519 ssh key can be solve by updating the libgit2 library in the objective-git library. There are several related issues:

• Any plan on a new release? libgit2/objective-git#693
• Failed to build current master branch using Carthage libgit2/objective-git#692

Similar with our previous PGP library, I'm thinking some alternatives (which should be more reliably and full functional).

[mssun]

Finally, I managed to update openssl (1.1.1d), libssh2 (1.9.0), libgit2(0.28.3) in my forked objective-git: mssun/objective-git@4c7b5d1. Pass has been updated in this commit 81eb4b8

Now, these dependencies are in the latest release. This means that ED25519 works now!

I don't have a full list of supported key algorithms, but supported algorithms can be checked in this file:
https://github.com/libssh2/libssh2/blob/libssh2-1.9.0/src/hostkey.c

CI is still working to compile a new release (https://travis-ci.org/mssun/passforios/builds/614401033). Once it's done, we can roll out a TestFlight for testing. Thanks.

[mssun]

In TestFlight 0.8.0 (41), please take a look.

[ismail]

In TestFlight 0.8.0 (41), please take a look.

Just tested, clone & pull works just fine. Great work!

[mssun]

Closed, 0.8.0 (41) has been published in App Store.

Feel free to reopen this or create a new one if there are more related issues.