Skip to content

Commit 6761df0

Browse files
committed
add feedback
1 parent 0fdbd69 commit 6761df0

File tree

3 files changed

+121
-250
lines changed

3 files changed

+121
-250
lines changed

.gitignore.sql

-250
This file was deleted.
0 Bytes
Binary file not shown.

feedback.txt

+121
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,121 @@
1+
# Feedback
2+
3+
Group jackal: ikerumd, ruby7188
4+
5+
Commit hash: 88160a9b0b3c9876c9956450f2d48020227f797a
6+
7+
Final score: 66 / 71
8+
9+
## Style check
10+
11+
Score: 5 / 5
12+
13+
## ArrayDictionary
14+
15+
Score: 15 / 15
16+
17+
- PASS: testPutAndGetSameKeyRepeatedMany
18+
- PASS: testRemoveDuplicate
19+
- PASS: testContainsKeyBasic
20+
- PASS: testRemoveBasic
21+
- PASS: testIteratorEndsCorrectly
22+
- PASS: testIteratorRunsMultipleTimes
23+
- PASS: testGetMany
24+
- PASS: testPutAndGetSameKeyRepeated
25+
- PASS: testNonNullKeys
26+
- PASS: testIteratorsAreIndependent
27+
- PASS: testIteratorOverEmptyDictionary
28+
- PASS: testPutAndGetBasic
29+
- PASS: testIteratorUnusualKeys
30+
- PASS: testAddGetMany
31+
- PASS: testIteratorOverDictionaryWithOneElement
32+
- PASS: testGetErrorHandling
33+
- PASS: testLargeKeys
34+
- PASS: testRemoveErrorHandling
35+
- PASS: testIterator
36+
- PASS: testNullKey
37+
- PASS: testPutAndGetMany
38+
39+
## ChainedHashDictionary
40+
41+
Score: 25 / 30
42+
43+
- PASS: handlesNegativeHashCodesEfficiently
44+
- PASS: testInsertingDuplicatesDoesNotResize
45+
- PASS: testInternalStructure
46+
- PASS: testResizing
47+
- FAIL: testMethodIntegration
48+
49+
java.util.NoSuchElementException
50+
at datastructures.concrete.dictionaries.ArrayDictionary$ArrayDictionaryIterator.next(ArrayDictionary.java:172)
51+
at datastructures.concrete.dictionaries.ArrayDictionary$ArrayDictionaryIterator.next(ArrayDictionary.java:155)
52+
at datastructures.concrete.dictionaries.ChainedHashDictionary$ChainedIterator.next(ChainedHashDictionary.java:212)
53+
at datastructures.concrete.dictionaries.ChainedHashDictionary$ChainedIterator.next(ChainedHashDictionary.java:167)
54+
at privatetests.TestPrivateChainedHashDictionary.testMethodIntegration(TestPrivateChainedHashDictionary.java:128)
55+
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
56+
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
57+
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
58+
at java.lang.reflect.Method.invoke(Method.java:498)
59+
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
60+
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
61+
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
62+
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
63+
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:298)
64+
at org.junit.internal.runners.statements.FailOnTimeout$CallableStatement.call(FailOnTimeout.java:292)
65+
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
66+
at java.lang.Thread.run(Thread.java:745)
67+
68+
- PASS: testBigHashCodesAndNull
69+
- PASS: stressTest
70+
- PASS: testNegativeHashCode
71+
- PASS: testContainsMaintainsStateForIterator
72+
- PASS: testManyObjectsWithSameHashCode
73+
- PASS: testPutAndGetSameKeyRepeatedMany
74+
- PASS: testRemoveDuplicate
75+
- PASS: testContainsKeyBasic
76+
- PASS: testRemoveBasic
77+
- PASS: testIteratorEndsCorrectly
78+
- PASS: testIteratorRunsMultipleTimes
79+
- PASS: testGetMany
80+
- PASS: testPutAndGetSameKeyRepeated
81+
- PASS: testNonNullKeys
82+
- PASS: testIteratorsAreIndependent
83+
- PASS: testIteratorOverEmptyDictionary
84+
- PASS: testPutAndGetBasic
85+
- PASS: testIteratorUnusualKeys
86+
- PASS: testAddGetMany
87+
- PASS: testIteratorOverDictionaryWithOneElement
88+
- PASS: testGetErrorHandling
89+
- PASS: testLargeKeys
90+
- PASS: testRemoveErrorHandling
91+
- PASS: testIterator
92+
- PASS: testNullKey
93+
- PASS: testPutAndGetMany
94+
95+
## ChainedHashSet
96+
97+
Score: 10 / 10
98+
99+
- PASS: testPutAndGetSameKeyRepeatedMany
100+
- PASS: testContainsWithRemovesBasic
101+
- PASS: testRemoveDuplicate
102+
- PASS: testContainsMany
103+
- PASS: testRemoveBasic
104+
- PASS: testIteratorEndsCorrectly
105+
- PASS: stressTest
106+
- PASS: testPutAndGetSameKeyRepeated
107+
- PASS: testContains
108+
- PASS: testIteratorsAreIndependent
109+
- PASS: testNegativeHashCode
110+
- PASS: testIteratorUnusualKeys
111+
- PASS: testAddAndCheckMany
112+
- PASS: testManyObjectsWithSameHashCode
113+
- PASS: testLargeKeys
114+
- PASS: testRemoveErrorHandling
115+
- PASS: testAddAndRemoveBasic
116+
- PASS: testIterator
117+
- PASS: testNullKey
118+
119+
## TestAvlTree
120+
121+
Score: 11 / 11

0 commit comments

Comments
 (0)