Bug 2045215 - [Perfherder][Comment_0] Alerts reassigned to a different summary are included in comment 0 when filing a new bug (#9772)

* fix: filter the textualSummary shown alerts

* refactor: use alertStatusMap for readability and move the filter logic to a reusable method

* fix: duplicate import

* test: adding test coverage for filterValidAlerts

* test: refactor test for better readability

Author: davidmiculit

tests/ui/perfherder/alerts-view/status_dropdown_test.jsx

@@ -6,6 +6,7 @@ import testPerformanceTags from '../../mock/performance_tags';
 import repos from '../../mock/repositories';
 import StatusDropdown from '../../../../ui/perfherder/alerts/StatusDropdown';
 import issueTrackers from '../../../../treeherder/perf/fixtures/issue_tracker';
+import { alertStatusMap } from '../../../../ui/perfherder/perf-helpers/constants';
 
 let testAlertSummary = testAlertSummaries[0];
 const testAlerts = testAlertSummary.alerts;
@@ -257,3 +258,32 @@ test("'Request backout' is not offered for a summary with no severity", async ()
   });
   expect(queryByText('Request backout')).toBeNull();
 });
+
+test('filterValidAlerts returns only valid alerts (acknowledged, untriaged, and valid reassigned)', () => {
+  const alertSummary = { id: 100 };
+  const dropdown = new StatusDropdown({
+    alertSummary,
+    frameworks: [],
+    filteredAlerts: [
+      { id: 1, status: alertStatusMap.acknowledged },
+      { id: 2, status: alertStatusMap.untriaged },
+      { id: 3, status: alertStatusMap.reassigned, summary_id: 99 },
+      { id: 4, status: alertStatusMap.reassigned, summary_id: 100 },
+      { id: 5, status: alertStatusMap.invalid },
+    ],
+  });
+
+  const validAlerts = dropdown.filterValidAlerts();
+
+  expect(validAlerts).toHaveLength(3);
+  expect(validAlerts.map(a => a.id)).toEqual([1, 2, 3]);
+});
+
+test('filterValidAlerts defaults to an empty array if filteredAlerts is undefined', () => {
+  const dropdown = new StatusDropdown({
+    alertSummary: { id: 100 },
+    frameworks: [],
+  });
+
+  expect(dropdown.filterValidAlerts()).toEqual([]);
+});

ui/perfherder/alerts/StatusDropdown.jsx

@@ -104,12 +104,21 @@ export default class StatusDropdown extends React.Component {
     return Array.from(new Set(names)).join(', ');
   };
 
+  filterValidAlerts = () => {
+    const { filteredAlerts = [], alertSummary } = this.props;
+    return filteredAlerts.filter(
+      (alert) =>
+        alert.status === alertStatusMap.acknowledged ||
+        alert.status === alertStatusMap.untriaged ||
+        (alert.status === alertStatusMap.reassigned && alert.summary_id !== alertSummary.id),
+    );
+  };
+
   fileBug = async (culpritId) => {
     const {
       alertSummary,
       repoModel,
       updateViewState,
-      filteredAlerts = [],
       frameworks,
       user,
     } = this.props;
@@ -128,9 +137,11 @@ export default class StatusDropdown extends React.Component {
       updateViewState,
     );
 
+    const validAlerts = this.filterValidAlerts();
+
     const textualSummary = new TextualSummary(
       frameworks,
-      filteredAlerts,
+      validAlerts,
       alertSummary,
       null,
       await browsertimeAlertsExtraData.enrichAndRetrieveAlerts(),
@@ -236,7 +247,6 @@ export default class StatusDropdown extends React.Component {
     const {
       alertSummary,
       repoModel,
-      filteredAlerts = [],
       frameworks,
       updateViewState,
       user,
@@ -256,9 +266,11 @@ export default class StatusDropdown extends React.Component {
       updateViewState,
     );
 
+    const validAlerts = this.filterValidAlerts();
+
     const textualSummary = new TextualSummary(
       frameworks,
-      filteredAlerts,
+      validAlerts,
       alertSummary,
       null,
       await browsertimeAlertsExtraData.enrichAndRetrieveAlerts(),
@@ -290,7 +302,7 @@ export default class StatusDropdown extends React.Component {
 
     // can't access the clipboardData on event unless it's done from react's
     // onCopy, onCut or onPaste props so using this workaround
-    navigator.clipboard.writeText(commentText).then(() => {});
+    navigator.clipboard.writeText(commentText).then(() => { });
   };
 
   async getBugTemplate(framework, updateViewState) {
@@ -346,7 +358,6 @@ export default class StatusDropdown extends React.Component {
       alertSummary,
       repoModel,
       updateViewState,
-      filteredAlerts = [],
       frameworks,
       user,
     } = this.props;
@@ -368,9 +379,11 @@ export default class StatusDropdown extends React.Component {
       return { failureStatus: 'Failed to retrieve bug template' };
     }
 
+    const validAlerts = this.filterValidAlerts();
+
     const textualSummary = new TextualSummary(
       frameworks,
-      filteredAlerts,
+      validAlerts,
       alertSummary,
       null,
       await browsertimeAlertsExtraData.enrichAndRetrieveAlerts(),